Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix base URI for PSScriptAnalyzer rule documentation #3608

Merged

Conversation

bgold09
Copy link
Contributor

@bgold09 bgold09 commented Oct 7, 2021

PR Summary

PR PowerShell/PSScriptAnalyzer#1724 moved all documentation to a new
directory in the repo. Therefore when a rule violation is detected in
the editor and a user uses the code action to navigate to the rule's
documentation, they are brought to an invalid URI.

Fixing the base URI to rule documentation in the PSScriptAnalyzer repo.

PR Checklist

Note: Tick the boxes below that apply to this pull request by putting an x between the square brackets.
Please mark anything not applicable to this PR NA.

  • PR has a meaningful title
  • Summarized changes
  • PR has tests
  • This PR is ready to merge and is not work in progress

@andyleejordan andyleejordan changed the title Fix base URI for rule documentation Fix base URI for PSScriptAnalyzer rule documentation Oct 8, 2021
Copy link
Member

@andyleejordan andyleejordan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great fix, thank you so much!

@andyleejordan andyleejordan enabled auto-merge (squash) October 8, 2021 16:41
@andyleejordan andyleejordan linked an issue Oct 8, 2021 that may be closed by this pull request
4 tasks
@andyleejordan andyleejordan merged commit 8f40aa1 into PowerShell:master Oct 8, 2021
@bgold09
Copy link
Contributor Author

bgold09 commented Oct 8, 2021

@andschwa no problem, it was an easy fix 😄

@bgold09 bgold09 deleted the dev/bgold09/fix/ruleDocumenationUri branch October 8, 2021 18:23
SyfiMeal added a commit to SyfiMeal/vscode-powershell that referenced this pull request Oct 23, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

PSScriptAnalyzer links from the Problem panel 404.
2 participants