Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update '.vscode/settings.json' to identify snippet files as 'JSON with Comments' #2065

Conversation

travisclagrone
Copy link
Contributor

@travisclagrone travisclagrone commented Jul 3, 2019

PR Summary

Updates the folder VS Code settings (i.e. .vscode/settings.json) to add

"files.associations": {
    "**/snippets/*.json": "jsonc"
}

This addition causes the developer's VS Code editor to associate snippets files with the "JSON with Comments" language, rather than "JSON".

This addition is motivated by the need for better source documentation of snippets (e.g. whether a particular prefix should be preserved for ISE compatibility). Obversely, this addition is justified by the fact that VS Code associates (known) snippet files with the "JSON with Comments" language anyway.

PR Checklist

  • PR has a meaningful title
  • Summarized changes
  • PR has tests
  • This PR is ready to merge and is not work in progress

…h Comments'

This change is motivated by the need for better source documentation (e.g. which snippet prefixes are for ISE compatibility), and is justified by the fact that VS Code itself identifies snippet files as 'JSON with Comments'.
Copy link
Contributor

@rkeithhill rkeithhill left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Member

@TylerLeonhardt TylerLeonhardt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM a nice addition to our vscode config!

@TylerLeonhardt TylerLeonhardt merged commit 172819f into PowerShell:master Jul 3, 2019
@travisclagrone travisclagrone deleted the interpret-snippets-files-as-jsonc branch July 4, 2019 23:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants