add machine scope #2039
Merged
add machine scope #2039
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
As mentioned, machine scope settings has two characteristics
|
This is what the
Yep perfect for exe paths. I guess I've done this right, but how do I test it? As in... How can I test a local build of an extension in a remote setup? |
rkeithhill
reviewed
Jun 21, 2019
package.json
Outdated
| @@ -755,6 +757,7 @@ | |||
| "powershell.developer.powerShellExePath": { | |||
| "type": "string", | |||
| "default": "", | |||
| "scope": "machine", | |||
| "isExecutable": true, | |||
| "description": "Deprecated. Please use the 'powershell.powerShellExePath' setting instead" | |||
There was a problem hiding this comment.
Maybe we should get rid of this deprecated setting? It has been deprecated for a long time.
rkeithhill
approved these changes
Jun 21, 2019
|
well it seems this PR broke our CI... so it did something... I'll switch the test to set a different setting... That makes me wonder... @sandy081 was
|
|
Ah. Missed that point, thanks! I'll update this PR to remove that. |
rjmholt
approved these changes
Jun 27, 2019
rjmholt
pushed a commit
to rjmholt/vscode-powershell
that referenced
this pull request
Jul 24, 2019
* add machine scope * use a different setting for test and add user setting test * remove isExecutable and remove powershell.developer.powerShellExePath
rjmholt
added a commit
that referenced
this pull request
Jul 26, 2019
* Edit snippets to support $TM_SELECTED_TEXT (#1945) Edit all-and-only applicable snippets to support $TM_SELECTED_TEXT, where "applicable" is approximated by whether a snippet contains a user-specified PowerShell expression, block, or body. Do not add, remove, or otherwise change any placeholder number or name in order to preserve backwards-compatibility. Edit the following snippets (listed by name, not prefix): - Class - Constructor - Method - Enum - Cmdlet - Function-Advanced - DSC Resource Provider (class-based) - DSC Resource Provider (function-based) - comment block - do-until - do-while - while - for - for-reversed - foreach - function - Function-Inline - if - elseif - else - switch - try-catch - try-catch-finally - try-finally - Workflow - Workflow ForEachParallel - Workflow InlineScript - Workflow Parallel - Workflow Sequence - Region Block - IfShouldProcess - CalculatedProperty - PesterDescribeContextIt - PesterDescribeBlock - PesterContextIt - PesterContext - PesterIt * Add ArgumentCompleter snippets (#1946) * Define snippet named 'ArgumentCompleterAttribute with ScriptBlock' * Define snippet named 'IArgumentCompleter Class' * Define snippet named 'ArgumentCompleterAttribute ScriptBlock' * Add #Requires snippets (#1974) * Add script requirement directive snippets Adds the following snippets (listed by name, not prefix): - Requires Assembly - Requires Assembly Path - Requires Assembly Version - Requires Module - Requires Module RequiredVersion - Requires Module Version - Requires PSEdition - Requires PSSnapin - Requires PSSnapin Version - Requires RunAsAdministrator - Requires ShellId - Requires Version * Fix node version detect logic to handle node v10 (#2025) * #1019: Get format settings from document editor instead of global. (#2035) * Update PSSA docs Url to point to master branch because master is now the default branch (#2037) * add machine scope (#2039) * add machine scope * use a different setting for test and add user setting test * remove isExecutable and remove powershell.developer.powerShellExePath * Add param-block snippet (#2081)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR Summary
Fixes #2024
Per the vscode team's request, we now need to mark executables with a
scope: "machine"to aid in remote development scenarios.@sandy081 is there a recommended way to test this change? I couldn't use Remote - Container because it just gives me the latest release of the PowerShell extension.
PR Checklist
Note: Tick the boxes below that apply to this pull request by putting an
xbetween the square brackets.Please mark anything not applicable to this PR
NA.WIP:to the beginning of the title and remove the prefix when the PR is ready