Interactive console does not provide command history in debugger

[daleecc]

System Details

• Operating system name and version: Windows 7 (64-Bit)
• VS Code version: 1.10.2
• PowerShell extension version: 0.10.0
• Output from $PSVersionTable:

Name                           Value
----                           -----
PSVersion                      5.0.10586.117
PSCompatibleVersions           {1.0, 2.0, 3.0, 4.0...}
BuildVersion                   10.0.10586.117
CLRVersion                     4.0.30319.42000
WSManStackVersion              3.0
PSRemotingProtocolVersion      2.3
SerializationVersion           1.1.0.1

Issue Description

When executing commands in the integrated terminal, the up and down arrows on the keyboard to browse through command history do not work.

For example:

1. Execute a command such as Get-Item
2. When the command is finished, I would expect to be able to press the up arrow on the keyboard and have Get-Item re-appear as the command to run. Instead, the command input remains blank.

[daviwil]

Are you typing in the command or using F8 to execute it? What is the output of the Get-History command? History should be working for you.

[daleecc]

Sorry missed some information. This is only an issue while debugging when a breakpoint is hit and commands are being manually entered via the terminal.

[daviwil]

Thanks! I'll check on that.

[daviwil]

Definitely a bug here. I'll fix it when I overhaul command history in a few days.

[DexterPOSH]

This is a pain, typing the commands again and again on the interactive console while debugging. Hoping this gets fixed soon.

[SeeminglyScience]

@bergmeister careful now, my price is steep 😉 (PowerShell/PSScriptAnalyzer#850)

[bergmeister]

@SeeminglyScience Phew, I'm glad you did not pick one of the many PSUseDeclaredVarsMoreThanAssignments issues that all require a re-write of the rule...
Jokes aside, I think your referenced issue is really important because it is a blocker for many people. I had it already in the back of my mind to look at it but you confirmed that it really needs to be investigated and hopefully properly fixed.

[Sharken03]

+1
SeeminglyScience has a commit ready since October 2017, but it seems that commit is just the tip of the iceberg. Anyways, would be really good with an ETA, as this issue prevents me from using VS Code with PowerShell.

[sdcscripts]

+1 Really am looking forward to seeing when the update is made to support this, As love vscode but have to resort back to ISE for basic debugging in pwsh :(

…

On Mon, 26 Mar 2018 at 10:48, Sharken03 ***@***.***> wrote: +1 SeeminglyScience has a commit ready since October 2017, but it seems that commit is just the tip of the iceberg. Anyways, would be really good with an ETA, as this issue prevents me from using VS Code with PowerShell. — You are receiving this because you commented. Reply to this email directly, view it on GitHub <#550 (comment)>, or mute the thread <https://github.com/notifications/unsubscribe-auth/AQYljh79JH47-0AZy6yJSVZM7lL0B038ks5tiLlygaJpZM4MeCh8> .

[WaynePlummer]

Any update on general availability for this fix yet? I am also in the group who want to drop the ISE but find this issue a show-stopper.

[bergmeister]

@WaynePlummer Current core work for it is happening in this PR: PowerShell/PowerShellEditorServices#672
But it might take some time afterwards for a release of the vscode-powershell, which is probably going to be of version 2 due to breaking changes (PowerShell versions before 5 will not be supported any more)

[ngetchell]

I generally debug code in the ISE for this reason. This is my last reservation.

[Sharken03]

@bergmeister
Thanks for the link to the pull request 672, now i am wondering if comments to that pull request should go on that thread or on this current thread.
Opting for the last choice, i have made the following observations:

• Starting a debug session with F5 should set focus to the editor window and not the terminal window. CTRL + 1 will return you to the editor window.
• It feels like a workaround to use F8 in order to move from editor window to the terminal window. But in practice it gets the job done.

[TylerLeonhardt]

@Sharken03, thanks for the feedback! Definitely leave comments on the PR so that we can address them.

As for your current comments, can you try setting powershell.integratedConsole.focusConsoleOnExecute to False and see if that accomplishes what you want?

[Sharken03]

@tylerl0706
With focusConsoleOnExecute set to False, the focus is set to the editor window. But now F8 will not set focus to the Terminal window, as that behavior is also controlled by focusConsoleOnExecute. Guess i will have to find another shortcut for setting focus to the terminal window.

Update:
Following the idea outlined on Stackoverflow, you can have a toggle to switch between editor window and the terminal. Note that if you are not using an english keylayout, then it is better to use CTRL+K CTRL+K, to let VS Code tell you what key that corresponds with.

[rkeithhill]

Here are a couple of keyboard shortcut customizations I use that you might find helpful:

  { "key": "ctrl+`",          "command": "workbench.action.focusActiveEditorGroup",
                                 "when": "!editorFocus" },
  { "key": "ctrl+`",          "command": "workbench.action.terminal.focus",
                                 "when": "!terminalFocus" },
  { "key": "ctrl+shift+q",    "command": "workbench.action.toggleMaximizedPanel" },

[thomasbtatum]

Just updated everything today and saw this feature is still missing. +1 ! 🙏

[TylerLeonhardt]

Soon ™ 😉

The PSReadLine PR is almost done.

[MalcolmTyler]

Any ETA yet on this bug fix being released?

[msevastian]

Struggling from the same problem since started to use VS Code for Powershell coding :( Up arrow just doesn't populate any last command entered in debugger. Guys any news when it can be fixed?

[rjmholt]

There's a preview build available to address this that you can find here: #535 (comment)

Please give it a try -- it's a pretty significant feature, so if you hit any problems please open an issue :)

[sba923]

I'm running 1.9.0 on VScode 1.27.2 (Windows, PowerShell 5.1), and still no history when debugging...

Am I missing something?

P.S. I do have the "PSReadLine" feature flag set.

[SeeminglyScience]

@sba923 Yeah, it's in the 2.0 which isn't released yet. There's a preview build in this comment if you'd like to help test though 🙂

[sba923]

IIRC I tried that vsix when it was announced in this thread, but it didn't work, and someone commented it can't work with PowerShell 5.1, only with PowerShell 6.x. Do you concur?

[rjmholt]

The latest build in that comment thread works with Windows PowerShell. There is still an extension command bug in it which is fixed upstream, but we're currently getting all the fixes in 1.9.0 into 2.0.0 so we can get an up-to-date AppVeyor build going — that way you won't need to pull from a comment.

[Sharken03]

With the PSReadline integration done in PowerShell/PowerShellEditorServices#672, i really hope version 2.0 is out soon as it is a really great improvement to VS Code.

[SydneyhSmith]

Closing as PSReadLine is now available in the PowerShell Preview extension, tracking that PSReadLine is not available in the main PowerShell Extension here #1793