-
Notifications
You must be signed in to change notification settings - Fork 499
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Install-VSCode doesn't support "Stable-User" BuildEdition #2048
Comments
The ValidateSet used to be just Stable and Insider, and was changed to Stable, Insider-System and Insider-User when that functionality became available for VS Code Insider. So Option 2 would be the way to go in my opinion. I'd like to pick this up :) |
Thanks, ghvanderweg. I'd like to take as well. Planning on using it as a demo on contributing to PowerShell/open source. |
Alright, it's all yours then 😀 |
Awesome! |
@TylerLeonhardt if @JMGEHMAN is picking this one up, should the Up-for-Grabs label be removed? |
I'll leave the tag for tracking but I did just assign it to @JMGEHMAN and we can use that for ownership. |
Changed Stable to Stable-System as discussed in Issue PowerShell#2048 (PowerShell#2048).
Changed Stable to Stable-System as discussed in Issue PowerShell#2048.
It took too long for me to get approval. Thanks to @Lothindir for fixing. |
The BuildEdition parameter of the Install-VSCode.ps1 script should support the "Stable-User" option - it currently only allows "Stable", which results in an install of "Stable-System.
If a user wants to install the Insiders version of VS Code, they have the option of specifying "Insider-System" or "Insider-User". However, there is only one option if selecting the "Stable" version.
Proposed technical implementation details (optional)
Add "Stable-User" to the ValidateSet check for the BuildEdition parameter. With the necessary changes to code to support the additional option. This creates an inconsistency between naming conventions for Stable and Insider editions - not sure what, if anything, should be done to address.
Keep "Stable" and simply add "Stable-User".
Rename "Stable" to "Stable-System" in addition to adding "Stable-User".
The text was updated successfully, but these errors were encountered: