Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Install-VSCode doesn't support "Stable-User" BuildEdition #2048

Closed
JMGEHMAN opened this issue Jun 24, 2019 · 7 comments
Closed

Install-VSCode doesn't support "Stable-User" BuildEdition #2048

JMGEHMAN opened this issue Jun 24, 2019 · 7 comments
Assignees
Labels
Issue-Enhancement A feature request (enhancement). Up for Grabs Will shepherd PRs.

Comments

@JMGEHMAN
Copy link

The BuildEdition parameter of the Install-VSCode.ps1 script should support the "Stable-User" option - it currently only allows "Stable", which results in an install of "Stable-System.

If a user wants to install the Insiders version of VS Code, they have the option of specifying "Insider-System" or "Insider-User". However, there is only one option if selecting the "Stable" version.

Proposed technical implementation details (optional)
Add "Stable-User" to the ValidateSet check for the BuildEdition parameter. With the necessary changes to code to support the additional option. This creates an inconsistency between naming conventions for Stable and Insider editions - not sure what, if anything, should be done to address.

  • Option 1
    Keep "Stable" and simply add "Stable-User".
[parameter()]
[ValidateSet("Stable", "Stable-User", "Insider-System", "Insider-User")]
[string]$BuildEdition = "Stable",
  • Option 2
    Rename "Stable" to "Stable-System" in addition to adding "Stable-User".
[parameter()]
[ValidateSet("Stable-System", "Stable-User", "Insider-System", "Insider-User")]
[string]$BuildEdition = "Stable-System",
@TylerLeonhardt TylerLeonhardt added Issue-Enhancement A feature request (enhancement). Up for Grabs Will shepherd PRs. labels Jun 24, 2019
@ghvanderweg
Copy link

The ValidateSet used to be just Stable and Insider, and was changed to Stable, Insider-System and Insider-User when that functionality became available for VS Code Insider. So Option 2 would be the way to go in my opinion.

I'd like to pick this up :)

@JMGEHMAN
Copy link
Author

Thanks, ghvanderweg. I'd like to take as well. Planning on using it as a demo on contributing to PowerShell/open source.

@ghvanderweg
Copy link

Alright, it's all yours then 😀

@TylerLeonhardt
Copy link
Member

Awesome!

@corbob
Copy link
Contributor

corbob commented Jun 28, 2019

@TylerLeonhardt if @JMGEHMAN is picking this one up, should the Up-for-Grabs label be removed?

@TylerLeonhardt
Copy link
Member

I'll leave the tag for tracking but I did just assign it to @JMGEHMAN and we can use that for ownership.

Lothindir added a commit to Lothindir/vscode-powershell that referenced this issue Aug 30, 2019
Lothindir added a commit to Lothindir/vscode-powershell that referenced this issue Aug 30, 2019
Changed Stable to Stable-System as discussed in Issue PowerShell#2048.
@JMGEHMAN
Copy link
Author

JMGEHMAN commented Oct 9, 2019

It took too long for me to get approval. Thanks to @Lothindir for fixing.

@JMGEHMAN JMGEHMAN closed this as completed Oct 9, 2019
@ghost ghost added the Needs: Maintainer Attention Maintainer attention needed! label Oct 9, 2019
@SydneyhSmith SydneyhSmith removed the Needs: Maintainer Attention Maintainer attention needed! label Oct 10, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Issue-Enhancement A feature request (enhancement). Up for Grabs Will shepherd PRs.
Projects
None yet
Development

No branches or pull requests

5 participants