fix folder permissions for programdata\ssh during server install #549
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
NoMoreFood
reviewed
Jan 3, 2022
bagajjal
reviewed
Jan 3, 2022
bagajjal
reviewed
Jan 4, 2022
bagajjal
reviewed
Jan 5, 2022
| # Folder permission is FullAccess to System and Builtin/Admins and read only access to Authenticated users, if user allows | ||
| Repair-SshFolderFilePermission -FilePath $sshProgDataPath @psBoundParameters | ||
| # All files besides private key files and log folder/files should have same permissions as ssh folder, if user allows | ||
| $restricted_files = @("ssh_host_dsa_key", "ssh_host_ecdsa_key", "ssh_host_ed25519_key", "ssh_host_rsa_key", "*.logs") |
There was a problem hiding this comment.
log files can have read only permissions for authenticated users
There was a problem hiding this comment.
Ok - I think the log files inherit from the log folder.
When the log folder is created by SSHD, it only allows Full Access to System & Admins.
I think either situation is permissible. Having a separate check for the log files/folders that permits read access for users, but won't add read access to users, if it has not already been granted might work best?
bagajjal
reviewed
Feb 4, 2022
fix comments
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PowerShell/Win32-OpenSSH#1900