Update Agent To Differentiate Key Types #377
Conversation
NoMoreFood
commented
Feb 26, 2019
NoMoreFood
commented
- Adjusted registry entires used by the SSH agent to include a SSH key type in the registry key name.
NoMoreFood
force-pushed
the
agent_issue
branch
2 times, most recently
from
0a1f377 to
37845e7
Compare
- Adjusted registry entires used by the SSH agent to include a SSH key type in the registry key name.
|
Adding a reference to related conversation - NoMoreFood@d7b6489 |
| @@ -154,7 +174,7 @@ process_add_identity(struct sshbuf* request, struct sshbuf* response, struct age | |||
| if ((!ConvertStringSecurityDescriptorToSecurityDescriptorW(REG_KEY_SDDL, SDDL_REVISION_1, &sa.lpSecurityDescriptor, &sa.nLength)) || | |||
| sshkey_to_blob(key, &pubkey_blob, &pubkey_blob_len) != 0 || | |||
| convert_blob(con, blob, blob_len, &eblob, &eblob_len, 1) != 0 || | |||
| ((thumbprint = sshkey_fingerprint(key, SSH_FP_HASH_DEFAULT, SSH_FP_DEFAULT)) == NULL) || | |||
| ((thumbprint = get_key_subkey_name(key)) == NULL) || | |||
There was a problem hiding this comment.
What is the advantage of appending ":key_type_string"?
Don't we need the same logic when we read from the registry to remove the ":key_typ_string"?
| @@ -179,6 +199,12 @@ process_add_identity(struct sshbuf* request, struct sshbuf* response, struct age | |||
| if ((success == 0) && reg && thumbprint) | |||
| RegDeleteKeyExA(reg, thumbprint, KEY_WOW64_64KEY, 0); | |||
|
|
|||
| /* delete previous version of thumbprint keys without type */ | |||
There was a problem hiding this comment.
Isn't the logic should be before we create the thumbprint?
line 180 on the right hand side adds the thumbprint to registry.
Line 203 deletes the thumbprint added in line 180?
|
@NoMoreFood - Could you please add the use case why this change is made? |
|
@bagajjal I'm going to close this for now. It was never updated in response to @manojampalam's suggestion. |
