Addressed SCP Hanging Issue #376
Conversation
NoMoreFood
commented
Feb 22, 2019
NoMoreFood
commented
- Changed fileio_fdopen() to simply return the file descriptor for non-disk file types.
- Addresses issue where an error message in SCP (server side) was not being returned to the pipe which causes the process to hang. Resolves: scp to non existing directory hangs Win32-OpenSSH#1345
- Changed fileio_fdopen() to simply return the file descriptor for non-disk file types. - Addresses issue where an error message in SCP (server side) was not being returned to the pipe which causes the process to hang. Resolves: PowerShell/Win32-OpenSSH#1345
| /* for non-disk files, just return the descriptor */ | ||
| type = GetFileType(pio->handle); | ||
| if (type != FILE_TYPE_DISK) { | ||
| return _fdopen(pio->table_index, mode); |
There was a problem hiding this comment.
relevant info - if the Windows handle associated with "fd" is originally opened as OVERLAPPED (as is the case with all file and pipe handles opened in the posix adapter), all synchronous operations on FILE returned by _fdopen will hang.
It is for that reason, the subsequent logic works around calling _fdopen directly on file handles. Are you not seeing the above behavior for pipe handles?
There was a problem hiding this comment.
No, I do not see a hang -- this returns the handle successfully for the named pipe. The only "hang" I see is that one caused by the get_final_path_by_handle() returning NULL for a non-disk file which prevents the parent function from receiving the pipe handle which in turns prevents the calling function from receiving the error and closing the connection.
