Enable Appverifier tests #191
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
PowerShell/Win32-OpenSSH#839 Appverifier tests are disable on sftp due to issue 841 which needs to be fixed in upstream
manojampalam
reviewed
Aug 4, 2017
|
|
||
| if($Global:OpenSSHTestInfo["EnableAppVerifier"] -and (Test-path $env:windir\System32\appverif.exe)) | ||
| { | ||
| & $env:windir\System32\appverif.exe -disable * -for * |
There was a problem hiding this comment.
What does this do ? can you put in some comments please?
There was a problem hiding this comment.
This just clean up the applications in application verifier.
|
@manojampalam I've updated the script. Please review. |
bagajjal
reviewed
Aug 4, 2017
| & $env:windir\System32\appverif.exe -verify $_.Name | out-null | ||
| } | ||
|
|
||
| <#$folderName = "x86" |
There was a problem hiding this comment.
Please delete this before you push your changes upstream
There was a problem hiding this comment.
I want to keep them to save time in case people want to set Postmortem Debugging when things got broken or even want to enable it in the future. :)
bagajjal
approved these changes
Aug 4, 2017
bingbing8
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Enable Appverifier tests and fix the below two issues:
PowerShell/Win32-OpenSSH#839
PowerShell/Win32-OpenSSH#841