terminal support for the accepting unicode input #162
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bingbing8
approved these changes
Jun 13, 2017
|
|
||
| p = p + strlen(p); | ||
| const char *permissions = "********* "; | ||
| for(int i = 0; i < strlen(permissions); i++) |
There was a problem hiding this comment.
strncpy is giving a warning to use strncpy_s..
To use strncpy_s we need to know the size of p.. since p is a char*, the caller can pass pointer to a memory (or) an array so we can't decide the size here.. so to avoid the warning.. changed it to for loop
| return; | ||
| wchar_t *buf = utf8_to_utf16(ansikey); | ||
|
|
||
| if (!buf) { |
There was a problem hiding this comment.
fatal is not available in shell-host.c and also printf() output is displayed on client side..
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Support the unicode characters as input to the ssh client.
Entering character ö prints two characters Win32-OpenSSH#711
Remove the bAnsi related code changes to the ssh-shellhost.c as that code never executes..
Fixed "long pressing key issue for the slow ssh connections"
Long-pressing arrow-keys prints control sequences instead of advancing cursor (Linux client) Win32-OpenSSH#701
fixed warning message in the latestw_all recent commits.
Fixed the issue with ssh failures in the latestw_all recent commits.