Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ripemd160 HMAC #517

Closed
farika opened this issue Feb 5, 2017 · 3 comments
Closed

ripemd160 HMAC #517

farika opened this issue Feb 5, 2017 · 3 comments

Comments

@farika
Copy link

farika commented Feb 5, 2017

Hello,

Normally openssh 7.4 support theses macs :
Ssh -q mac
hmac-sha1
hmac-sha1-96
hmac-sha2-256
hmac-sha2-512
hmac-md5
hmac-md5-96
hmac-ripemd160
[email protected]
[email protected]
[email protected]
[email protected]
[email protected]
[email protected]
[email protected]
[email protected]
[email protected]
[email protected]
[email protected]
[email protected]

Why Win32-openssh don't support ripemd ? Can you add this HMAC ? I found references to this Mac in the code.

OpenSSH-Win32> ./ssh -Q mac
hmac-sha1
hmac-sha1-96
hmac-sha2-256
hmac-sha2-512
hmac-md5
hmac-md5-96
[email protected]
[email protected]
[email protected]
[email protected]
[email protected]
[email protected]
[email protected]
[email protected]
[email protected]
[email protected]

Thanks

@manojampalam
Copy link
Contributor

manojampalam commented Feb 6, 2017

This is due to
#ifdef HAVE_EVP_RIPEMD160
{ "hmac-ripemd160", SSH_DIGEST, SSH_DIGEST_RIPEMD160, 0, 0, 0, 0 },
{ "[email protected]", SSH_DIGEST, SSH_DIGEST_RIPEMD160, 0, 0, 0, 0 },
#endif

HAVE_EVP_RIPEMD160 is not defined for the Windows project yet.
Do you know if OpenSSL 1.0.2* supports this?

If so, its a matter of defining this in config.h.vs

@farika
Copy link
Author

farika commented Feb 6, 2017

Thanks for you answer. Yes it's ok for OpenSSL. https://wiki.openssl.org/index.php/Manual:Ripemd(3)
$ openssl list-message-digest-commands
md4
md5
mdc2
rmd160
sha
sha1
$ openssl rmd160 /usr/bin/openssl
RIPEMD160(/usr/bin/openssl)

Before using Win32-Openssh I used the openssh version 7.4 by mls (cygwin) which supports the ripemd. It is useful on some old servers without SHA256 and to avoid the SHA-1 .

@manojampalam
Copy link
Contributor

Fixed in 0.0.9.0

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants