Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

SqlRSSetup: Will always make an edition upgrade #1311

Open
johlju opened this issue Mar 18, 2019 · 0 comments
Open

SqlRSSetup: Will always make an edition upgrade #1311

johlju opened this issue Mar 18, 2019 · 0 comments
Labels
bug The issue is a bug. help wanted The issue is up for grabs for anyone in the community.

Comments

@johlju
Copy link
Member

johlju commented Mar 18, 2019

Details of the scenario you tried and the problem that is occurring

The parameter EditionUpgrade currently does not work. The resource will always make an edition upgrade if the configuration is change to use for example another Edition value.

Verbose logs showing the problem

n/a

Suggested solution to the issue

The function Test-TargetResource should handle this. Find a way to look what edition is currently installed. If the currently installed edition differs from what the configuration wants (and it is upgradable, e.g 'Eval' to 'Dev'), and EditionUpgrade is set to $true, then run Set-TargetResource. If the EditionUpgrade is set to $false (or not provided) Set-TargetResource should not be called even if the edition differs.

The DSC configuration that is used to reproduce the issue (as detailed as possible)

First run installs evaluation:

SqlRSSetup 'InstallDefaultInstance'
{
    InstanceName          = 'SSRS'
    IAcceptLicenseTerms   = 'Yes'
    SourcePath            = 'C:\InstallMedia\SQLServerReportingServices.exe'
    Edition               = 'Evaluation'

     PsDscRunAsCredential = $SqlInstallCredential
}

Second run upgrades the edition to 'Development':

SqlRSSetup 'InstallDefaultInstance'
{
    InstanceName          = 'SSRS'
    IAcceptLicenseTerms   = 'Yes'
    SourcePath            = 'C:\InstallMedia\SQLServerReportingServices.exe'
    Edition               = 'Development'
    EditionUpgrade        = $false

     PsDscRunAsCredential = $SqlInstallCredential
}

SQL Server edition and version the target node is running

Microsoft SQL Server Reporting Services 2017 (October 2017)

SQL Server PowerShell modules present on the target node

n/a

The operating system the target node is running

n/a

Version and build of PowerShell the target node is running

n/a

Version of the DSC module that was used ('dev' if using current dev branch)

Dev

@johlju johlju added bug The issue is a bug. help wanted The issue is up for grabs for anyone in the community. labels Mar 18, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug The issue is a bug. help wanted The issue is up for grabs for anyone in the community.
Projects
None yet
Development

No branches or pull requests

1 participant