Fix hostname support for Enterprise installations of GitHub #118
Conversation
There was a problem hiding this comment.
Please re-submit without all the miscellaneous formatting changes.
@Cellivar - this will be a breaking change for you (you'll have to update your instances to specify api. with your hostname.
|
remarks regarding this code change: GitLab API Version (and url) is updated to V4 -> https://docs.gitlab.com/ee/api/v3_to_v4.html. This change is still using V3 (not supported in GitLab 11.0 and higher). Just changing the URL to v4 results in authentication errors in my environment (tested with valid token):
This change is only supporting https - but not http. Support for http would be great. |
@GitTill - The GitLab and GitHub API's are quite different. This module is not designed to work with GitLab...only GitHub. I took a look at their website and found a reference to PSGitlab as an unofficial PowerShell client for their API. You may want to look at that module. |
.vscode/settings.json
Outdated
| @@ -0,0 +1,4 @@ | |||
| { | |||
There was a problem hiding this comment.
At present time, I don't want to check-in editor-specific files into the project. I realize that you added this as a result of needing to undo your other formatting changes , and I'm open to being convinced otherwise, but at the moment I'm not.
There was a problem hiding this comment.
ah ...how do i remove the file...just add it to gitignore?
There was a problem hiding this comment.
- delete the file
git add .vscode/settings.jsongit commitgit push
There was a problem hiding this comment.
thanks...this is done
GitHubCore.ps1
Outdated
| @@ -153,7 +153,14 @@ function Invoke-GHRestMethod | |||
|
|
|||
| $hostName = $(Get-GitHubConfiguration -Name "ApiHostName") | |||
|
|
|||
| $url = "https://api.$hostName/$UriFragment" | |||
| if ($hostName -eq "github.com") | |||
There was a problem hiding this comment.
I have generally been avoiding double-quoted strings unless I am expecting for them to be interpreted due to embedded expressions/variables/etc...
| if ($hostName -eq "github.com") | |
| if ($hostName -eq 'github.com') |
There was a problem hiding this comment.
:) sure...i will change to single
HowardWolosky
changed the title
Per the documentation, enterprise installations support a base URL of
http(s)://[hostname]/api/v3in addition to the existing support ofhttp(s)://api.[hostname]/. This PR updates the module to always use thehttp(s)://[hostname]/api/v3syntax when[hostname]is notgithub.com.Fixes #117