Add URL config for GitHub Enterprise #101
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
|
AppVeyor CI is not visible for me so I can't check :( |
HowardWolosky
requested changes
Apr 8, 2019
There was a problem hiding this comment.
Thanks so much for this feature. It sounds like this should definitely further open up the available userbase.
I've included some minor change requests before this would be merged in.
I think it would also be great to include a minor documentation update to point out this specific configuration. It probably makes sense to call it out within the Configuration section of the README.
Thanks again!
HowardWolosky
requested changes
Apr 9, 2019
HowardWolosky
approved these changes
Apr 10, 2019
|
No problem! Thank you for your patient guidance while I shook the rust off my public contribution skills. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I think I ran the pester tests correctly, or at least they all came back green for me anyhow. Static analysis also came back empty.
This resolves #98 with the ability to supply a new configuration parameter,
GitHubBaseUrl. It will default togithub.com. GitHub Enterprise installs to a different URL and the API remains asapi.somegithub.com, thus it's simple to hit that API on a different base URL.I've been using a similar set of changes along with a few other quality of life ones in my organization over the past week as we prototyped out some tools around automating GitHub Enterprise. It performed admirably with these changes here.
Fixed a related typo in the documentation as well.