Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update NewtonSoft.Json dependency from 10.0.3 to 11.02 since PS 6.0 has been deprecated #981

Merged
merged 2 commits into from
Jun 25, 2019

Conversation

bergmeister
Copy link
Contributor

@bergmeister bergmeister commented Jun 21, 2019

Update NewtonSoft.Json dependency to 11.02 since PowerShell 6.0 has been deprecated. This version of Newtonsoft is the one shipped with PS 6.1, see source code here. It's version cannot be higher than the one shipped in PowerShell due to DLL unloading not being possible.

Context: At the moment, I am experimenting with attaching PSSA as a .Net NuGet library directly to it and it fails because it detects the package downgrade (PSSA already updated Newtonsoft directly after PS 6.0 had been deprecated)

This is a candidate for 1.x as well but the might need to be done manually in that branch itself as its csproj layout is probably too different.

…een deprecated. This version of Newtonsoft is the one shipped with PS 6.1. It's version cannot be higher than the one shipped in PowerShell due to DLL unloading not being possible.
@bergmeister bergmeister changed the title Update NewtonSoft.Json dependency to 11.02 since PowerShell 6.0 has b… Update NewtonSoft.Json dependency from 10.0.3 to 11.02 since PS 6.0 has been deprecated Jun 21, 2019
@bergmeister bergmeister marked this pull request as ready for review June 21, 2019 10:00
@bergmeister bergmeister requested a review from rjmholt as a code owner June 21, 2019 10:00
Copy link
Member

@TylerLeonhardt TylerLeonhardt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM thanks, Chris!

@bergmeister
Copy link
Contributor Author

bergmeister commented Jun 21, 2019

You're welcome. Is it worthwhile throwing an explicit error in the module if someone is still on 6.0? There is still some left-over code for 6.0 code here that we could change to throw explicity, PSSA does that here btw

@TylerLeonhardt
Copy link
Member

Thanks, @bergmeister! We already have that in place. I added in when we switched our Named Pipes implementation

@TylerLeonhardt
Copy link
Member

This is a candidate for 1.x as well but the might need to be done manually in that branch itself as its csproj layout is probably too different.

We have dependabot on for the legacy branch so there shouldn't need to be any manual processes

@TylerLeonhardt TylerLeonhardt merged commit e466f3c into PowerShell:master Jun 25, 2019
bergmeister added a commit to bergmeister/PowerShellEditorServices that referenced this pull request Jun 29, 2019
@bergmeister
Copy link
Contributor Author

This is a candidate for 1.x as well but the might need to be done manually in that branch itself as its csproj layout is probably too different.

We have dependabot on for the legacy branch so there shouldn't need to be any manual processes

No, Newtonsoft is ignored by dependabot because we cannot just take the latest version of it, we can only take the latest version in the oldest supported version of PSCore. I opened #983 for a backport of this PR

@TylerLeonhardt
Copy link
Member

TylerLeonhardt commented Jun 29, 2019

Sorry, I meant besides updating the versions in the legacy branch, we shouldn't need to do anything.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants