-
Notifications
You must be signed in to change notification settings - Fork 223
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update NewtonSoft.Json dependency from 10.0.3 to 11.02 since PS 6.0 has been deprecated #981
Update NewtonSoft.Json dependency from 10.0.3 to 11.02 since PS 6.0 has been deprecated #981
Conversation
…een deprecated. This version of Newtonsoft is the one shipped with PS 6.1. It's version cannot be higher than the one shipped in PowerShell due to DLL unloading not being possible.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM thanks, Chris!
Thanks, @bergmeister! We already have that in place. I added in when we switched our Named Pipes implementation |
We have dependabot on for the legacy branch so there shouldn't need to be any manual processes |
… 6.0 has been deprecated. Backport of PowerShell#981
No, |
Sorry, I meant besides updating the versions in the legacy branch, we shouldn't need to do anything. |
Update NewtonSoft.Json dependency to 11.02 since PowerShell 6.0 has been deprecated. This version of Newtonsoft is the one shipped with PS 6.1, see source code here. It's version cannot be higher than the one shipped in PowerShell due to DLL unloading not being possible.
Context: At the moment, I am experimenting with attaching PSSA as a .Net NuGet library directly to it and it fails because it detects the package downgrade (PSSA already updated Newtonsoft directly after PS 6.0 had been deprecated)
This is a candidate for 1.x as well but the might need to be done manually in that branch itself as its csproj layout is probably too different.