Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

WIP Fix Remove empty catch block. #985

Conversation

bergmeister
Copy link
Collaborator

@bergmeister bergmeister commented May 5, 2018

PR Summary

An empty catch block was found in the code and was removed as I cannot see a reason for an exception and if so I would rather like to see a future bug report.
Since the fix was so simple, I was not sure if it is really worth having a test for it?

PR Checklist

Note: Tick the boxes below that apply to this pull request by putting an x between the square brackets. Please mark anything not applicable to this PR NA.

  • PR has a meaningful title
    • Use the present tense and imperative mood when describing your changes
  • Summarized changes
  • NA User facing documentation needed
  • Change is not breaking
  • Make sure you've added a new test if existing tests do not effectively test the code changed => I'm not sure if it is really worth having a test for that since the code fix was quite simple.
  • This PR is ready to merge and is not work in progress
    • If the PR is work in progress, please add the prefix WIP: to the beginning of the title and remove the prefix when the PR is ready

@bergmeister bergmeister changed the title Fix NullReferenceException when CimSuperClass is null and remove empty catch block. WIP Fix NullReferenceException when CimSuperClass is null and remove empty catch block. May 11, 2018
@bergmeister bergmeister changed the title WIP Fix NullReferenceException when CimSuperClass is null and remove empty catch block. WIP Fix Remove empty catch block. Oct 3, 2018
@rjmholt rjmholt marked this pull request as draft April 21, 2021 21:14
@andyleejordan andyleejordan deleted the branch PowerShell:development September 11, 2024 22:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants