Scripts needed to build and sign PSSA via MS VSTS so it can be published in the gallery #983
Conversation
|
Some ps1 and psm1 files are missing the copyright header and some commented out lines are left in there |
| @@ -0,0 +1,34 @@ | |||
| # escape=` | |||
| #0.3.6 (no powershell 6) | |||
| # FROM microsoft/windowsservercore | |||
There was a problem hiding this comment.
nit: this line can be removed
| "Windows": { | ||
| "Name": "win7-x64", | ||
| "RepoDestinationPath": "C:\\PSScriptAnalyzer", | ||
| "BuildCommand": "C:\\containerFiles\\buildPSSA.ps1", |
There was a problem hiding this comment.
non-blocking:
_DockerVolume_ is supposed to be passed as a parameter for where you are supposed to copy the results to.
This will become more important when we migrate to a new build system and the path is not the same
|
My comment is not blocking as well. I do not think it makes sense for me to review this PR in this special case. Whatever works fine for you guys is OK. |
Updated docker file and releasemaker module
…d on _DockerVolume_ Remove a comment
JamesWTruher
force-pushed
the
jameswtruher/release01
branch
from
deab984 to
82ebc03
Compare
…ere based on _DockerVolume_" This reverts commit 82ebc03.
|
we build now and create appropriately signed binaries - I opened issue #993 to track when we move to new build/signing infrastructure |
| # escape=` | ||
| #0.3.6 (no powershell 6) | ||
| # FROM microsoft/windowsservercore | ||
| FROM microsoft/dotnet-framework:4.7.1 |
There was a problem hiding this comment.
@TravisEz13 @JamesWTruher Could building with .net 4.7.1 cause issues for customers that do not have this relatively new runtime installed?
There was a problem hiding this comment.
For Full DotNet, it is supposed to be compatible between major versions unless the product uses features that are specific to the newer version. I've worked on other products that did exactly what this is doing but were just very careful not to use newer features.
PR Summary
In order to meet the release gates Microsoft has with regard to software publishing, the module must be built in a specific way and signed in a specific manner. This PR provides all the scripts needed to meet those gates and automate the release build for publishing.
This code does not affect script analyzer in any way other than to provide an alternative build mechanism.
PR Checklist
Note: Tick the boxes below that apply to this pull request by putting an
xbetween the square brackets. Please mark anything not applicable to this PRNA.WIP:to the beginning of the title and remove the prefix when the PR is ready