Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix dependabot issues by upgrading newtonsoft json library to 13.0.1 #1815

Merged
merged 1 commit into from
Jul 5, 2022

Conversation

JamesWTruher
Copy link
Contributor

PR Summary

dependabot recommended upgrade to our newtonsoft library

PR Checklist

@JamesWTruher JamesWTruher requested a review from bergmeister June 30, 2022 16:40
@JamesWTruher JamesWTruher merged commit e6005a9 into PowerShell:master Jul 5, 2022
@bergmeister
Copy link
Collaborator

@JamesWTruher I think we should revert this. We've always ignored them because we should not use a version higher than the one of the oldest used PowerShell 'Core' version (which in this case is PS 7.0) because if someone was to use and load PSSA first, the behavior of that PowerShell instance will be different (and likely more breaking) as PowerShell Core cannot unload assemblies once they are already loaded.
https://github.com/PowerShell/PSScriptAnalyzer/pulls?q=is%3Apr+bump+newtonsoft+is%3Aclosed+

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants