Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Upgrade from net452 to net462 for Windows PowerShell #1789

Merged
merged 8 commits into from
Jul 5, 2022

Conversation

bergmeister
Copy link
Collaborator

@bergmeister bergmeister commented Apr 23, 2022

PR Summary

Upgrading since older framework version will go out of support and and targeting a newer version will allow us to use more APIs. 4.6.2 is the older, still supported one
https://devblogs.microsoft.com/dotnet/net-framework-4-5-2-4-6-4-6-1-will-reach-end-of-support-on-april-26-2022/

As part of it I also fixed a bug that was introduced in PR #1425 where one line of code wasn't upgraded from PSV6 to PSV7

Furthermore APIs are being used that are in net462 but weren't available in net452

PR Checklist

@bergmeister bergmeister marked this pull request as ready for review May 27, 2022 16:22
Copy link
Contributor

@JamesWTruher JamesWTruher left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good

@JamesWTruher JamesWTruher merged commit b030262 into PowerShell:master Jul 5, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants