Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Invoke-Formatter: Accept input from pipeline #1763

Merged
merged 3 commits into from
Aug 11, 2022

Conversation

bergmeister
Copy link
Collaborator

@bergmeister bergmeister commented Jan 19, 2022

PR Summary

Implements #1761

PR Checklist

@bergmeister bergmeister changed the title Invoke-Formatter: Accept input from pipeline for main -ScriptDefinition parameter Invoke-Formatter: Accept input from pipeline Jan 19, 2022
@kilasuit
Copy link
Contributor

LGTM @bergmeister :-)

@bergmeister
Copy link
Collaborator Author

Close and re-open so that Github removes the pending MacOs check which has been fixed/removed upstream in master

@bergmeister bergmeister reopened this Jan 28, 2022
@JamesWTruher JamesWTruher added this to the 1.21 milestone Jul 25, 2022
@bergmeister bergmeister mentioned this pull request Aug 11, 2022
6 tasks
'foo' | Invoke-Formatter | Should -Be 'foo'
}
It 'Value from Pipeline by Property Name with just the mandatory ScriptDefinition parameter' {
[pscustomobject]@{ 'ScriptDefinition' = 'foo' } | Invoke-Formatter | Should -Be 'foo'
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
[pscustomobject]@{ 'ScriptDefinition' = 'foo' } | Invoke-Formatter | Should -Be 'foo'
[pscustomobject]@{ 'ScriptDefinition' = 'command1;command2' } | Invoke-Formatter | Should -Be 'command1; command2'

Copy link
Contributor

@JamesWTruher JamesWTruher left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this looks fine - just one suggestion below

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants