-
Notifications
You must be signed in to change notification settings - Fork 383
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Implement -IncludeSuppressions parameter #1701
Merged
rjmholt
merged 20 commits into
PowerShell:master
from
rjmholt:includesuppressions-parameter
Aug 4, 2021
+319
−155
Merged
Changes from 1 commit
Commits
Show all changes
20 commits
Select commit
Hold shift + click to select a range
93a0b02
Implement IncludeSuppressed switch to emit suppressed diagnostics as …
rjmholt e5c48e5
Add tests
rjmholt a2c64a3
Fix default parameter set
rjmholt c99cf42
Use mandatory to tie break parameter binding
rjmholt 8fbbaf7
Fix parameter set processing
rjmholt a450a42
Fix parameter set names
rjmholt 273d0d6
Fix parameter set tests
rjmholt bcf66f9
Update help for new parameter set
rjmholt 643ff4c
Reinstate bad parameter set for -Recurse
rjmholt c50eed5
Fix help tests to include cmdlet parameters
rjmholt 9548bcd
Fix PSSA build asset path
rjmholt 4ebe0bb
Wrestle with modules
rjmholt d91a6f3
Get module info
rjmholt 5465831
Fix
rjmholt ea28d2b
Show command
rjmholt fdaca95
Update internal Invoke-ScriptAnalyzer redefinition to conform with cm…
rjmholt 8d09ac0
Fix LibraryUsage tests
rjmholt 50bdfa9
Add IsSuppressed property to diagnostics
rjmholt 6e9e30c
Clean up processing logic in Invoke-ScriptAnalyzer
rjmholt 02ccd84
Update README with new parameter syntax
rjmholt File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Add IsSuppressed property to diagnostics
commit 50bdfa90146c4f6158768b84221a2f861bd5f6da
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Could this ever be called with a suppression list count of zero? In that case IsSuppressed really true?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Very good question. I think the mere wrapping in the
SuppressedRecord
object classes the diagnostic as suppressed, but I agree that this opens up the possibility of an invalid object, which I dislike... I'm not sure I see a way around this without changing a few things around though, and I'm not sure that's worth it.