Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

move to new signing process for release build and prep for 1.20.0 #1625

Merged
merged 36 commits into from
Apr 22, 2021

Conversation

JamesWTruher
Copy link
Contributor

PR Summary

The infrastructure at MS has changed with regard to signing, this PR allows us to use it.

PR Checklist

@JamesWTruher JamesWTruher self-assigned this Jan 13, 2021
@rjmholt rjmholt self-requested a review January 13, 2021 19:15
Copy link
Collaborator

@bergmeister bergmeister left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good but the build seems to be broken. Also wondering whether 1.20.0 would be a better target version since the changes are all small improvements but not fixes

@JamesWTruher
Copy link
Contributor Author

I've rebased to be up to date.

@bergmeister, @rjmholt, @SydneyhSmith - Chris is suggesting that our next release should perhaps be number 1.20.0 and I wanted everyone to have a chance to provide an opinion. FWIW, I'm ok with 1.20

Copy link
Contributor

@rjmholt rjmholt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM -- agree that 1.20 seems good

Copy link
Member

@TravisEz13 TravisEz13 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks about right to me

@bergmeister bergmeister changed the title move to new signing process for release build and prep for 1.19.2 move to new signing process for release build and prep for 1.20.0 Feb 10, 2021
Copy link
Contributor

@rjmholt rjmholt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Generally looks good, just a small comment about the Write-Host invocations

.ci/releaseBuild.yml Outdated Show resolved Hide resolved
Co-authored-by: Robert Holt <[email protected]>
.ci/releaseBuild.yml Outdated Show resolved Hide resolved
.ci/releaseBuild.yml Outdated Show resolved Hide resolved
.ci/releaseBuild.yml Outdated Show resolved Hide resolved
.ci/releaseBuild.yml Outdated Show resolved Hide resolved
@rjmholt rjmholt merged commit 6bdc6f4 into PowerShell:master Apr 22, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants