-
Notifications
You must be signed in to change notification settings - Fork 382
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Pester v5 #1444
Pester v5 #1444
Conversation
…some -Skip problems already
…1 to fix indentation
… into pesterv5PoC # Conflicts: # Tests/Rules/UseUsingScopeModifierInNewRunspaces.tests.ps1
@rjmholt @JamesWTruher Pester v5 has released today after multiple RC iterations. It's much cleaner but a tad slower, especially on PowerShell 5.1, which hasn't back-ported the speculative execution perf fix PowerShell/PowerShell#10269 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Part way through the review, will continue later
PR Summary
Migration to use new Pester v5.
It has cleaner scoping and test setup has to go into a
BeforeAll
block, except for things that need to be evaluated at discovery time (therefore test cases also had to be inlined), see https://github.com/pester/Pester/blob/v5.0/README.mdSome cleanup had to be done as part of it. PSScriptAnalyzer is now only imported once before running tests (import is needed as some tests reference the PSSA types). Some tests were also cleaned up to not depend on
PSScriptAnalyzerTestHelper.psm1
any more. I also started adding the Copyright header to the test files. The speed of test execution is roughly the same as v4.A diff that ignores indentation/whitespace will make the review much easier
I suggest we wait for the GA of v5 but the PR is already ready.
PR Checklist
.cs
,.ps1
and.psm1
files have the correct copyright headerWIP:
to the beginning of the title and remove the prefix when the PR is ready.