Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove redundant whitespace between parameters with new option (disabled by default) in UseConsistentWhitespace #1392

Merged

Conversation

bergmeister
Copy link
Collaborator

PR Summary

Disabled by default because it is new. The plan is to later add an option to the vs code extension and pending positive feedback we can then later enable it by default.
The only case that was excluded by design is when the user uses the -ParameterName:$ParameterValue syntax as some people might prefer 0 or 1 whitespace here, the rule leaves those cases completely untouched.

PR Checklist

@bergmeister bergmeister changed the title Remove redundant white space between parameters with new option (disabled by default) in UseConsistentWhitespace Remove redundant whitespace between parameters with new option (disabled by default) in UseConsistentWhitespace Jan 5, 2020
Rules/UseConsistentWhitespace.cs Outdated Show resolved Hide resolved
Rules/UseConsistentWhitespace.cs Outdated Show resolved Hide resolved
Rules/UseConsistentWhitespace.cs Outdated Show resolved Hide resolved
Rules/UseConsistentWhitespace.cs Outdated Show resolved Hide resolved
Rules/UseConsistentWhitespace.cs Outdated Show resolved Hide resolved
Rules/UseConsistentWhitespace.cs Show resolved Hide resolved
Rules/UseConsistentWhitespace.cs Outdated Show resolved Hide resolved
Rules/UseConsistentWhitespace.cs Outdated Show resolved Hide resolved
Rules/UseConsistentWhitespace.cs Outdated Show resolved Hide resolved
Tests/Rules/UseConsistentWhitespace.tests.ps1 Show resolved Hide resolved
bergmeister and others added 4 commits January 6, 2020 21:39
@bergmeister
Copy link
Collaborator Author

@rjmholt Thanks for the review, I addressed all recommendations

@bergmeister bergmeister merged commit b0a67c7 into PowerShell:master Jan 7, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants