Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix configuration for PS v5 and v6 builds to be Debug/Release and not PSV6Debug, etc. as it used to be able to produce actual debug builds #1356

Merged
merged 2 commits into from
Nov 12, 2019

Conversation

bergmeister
Copy link
Collaborator

@bergmeister bergmeister commented Oct 26, 2019

PR Summary

The special PSV4Debug and PSV3Debug configurations apply only to builds of v3 and v4. The other builds do not need that and should just be Debug/Release as a config. At the moment this makes Debug build actually be Release builds, which this PR fixes. cc @thomasrayner
This minor regression was introduced in the build module refactoring of PR #1139

PR Checklist

…sed to be to allow for actual debug builds
@bergmeister bergmeister reopened this Nov 11, 2019
@bergmeister bergmeister merged commit 468212a into PowerShell:master Nov 12, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants