Fix compatibility profile query API so that aliases referring to other modules appear

[rjmholt]

PR Summary

Previously because of bad assumptions I made, an alias in a module that aliases a command outside that module would just be omitted from that module's query API.

I originally "fixed" this by building a table of aliases at profiling time and putting the aliases back into the modules of the commands they referenced. Not only was that wrong, but it also made profiling much slower.

Functionally, rules will see no differences and there are no breaking changes in the API, BUT this fixes the alias thing and should speed up profiling significantly (the latter being something I need).

PR Checklist

• PR has a meaningful title
  • Use the present tense and imperative mood when describing your changes
• Summarized changes
• Change is not breaking
• Make sure all .cs, .ps1 and .psm1 files have the correct copyright header
• Make sure you've added a new test if existing tests do not effectively test the code changed and/or updated documentation
• This PR is ready to merge and is not Work in Progress.
  • If the PR is work in progress, please add the prefix WIP: to the beginning of the title and remove the prefix when the PR is ready.

[rjmholt]

Not sure why the git diff is so large. I tried making the changes in that file again but the git diff is still huge. No encoding change either.

[bergmeister]

@rjmholt Using a whitespace ignoring diff, it is only a magnitude of ~ 100 lines changed, maybe there were some tabs in the original code (please don't tell me you're using tabs 😜)

[rjmholt]

maybe there were some tabs in the original code (please don't tell me you're using tabs 😜)

Shouldn't be -- I press Tab but that should expand to 4 spaces. Either way I wrote the file originally.

Anyway, I tried redoing the changes in a fresh commit and that didn't work... But the psm1 changes just delete the alias table stuff.

[bergmeister]

Looks, Ok, just the questions around case insensitive dictionaries and one optional style comment about using named tuples

[rjmholt]

@JamesWTruher I've just added some extra tests to capture aliases that are created outside the module of the command they refer to. The only ones I'm aware of are in the engine, and I dealt with them a different way before this change, so the tests will pass in both cases. But they do test that aliases defined elsewhere are still picked up.

[JamesWTruher]

looks fine to me (once the merge conflicts are addressed), thanks for adding more tests!

[rjmholt]

Ok I've rebased now. Let's see what the tests say