Add support for Hashtable syntax of Import-DscRessource for -SaveDscDependency switch #1138
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bergmeister
changed the title
bergmeister
changed the title
bergmeister
added
the
(Re-)Review Needed
rjmholt
approved these changes
Mar 5, 2019
bergmeister
added a commit
to bergmeister/PSScriptAnalyzer
that referenced
this pull request
Mar 5, 2019
bergmeister
added a commit
to bergmeister/PSScriptAnalyzer
that referenced
this pull request
Mar 22, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR Summary
Per title. In a future PR I might also add support for arrays of hashtables but I'd rather like to add those features slowly step by step to keep the diff small because the next PR will require refactoring of code to avoid code duplication.
Also use C# pattern matching for code cleanup.
PR Checklist
.cs,.ps1and.psm1files have the correct copyright headerWIP:to the beginning of the title and remove the prefix when the PR is ready.