Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Give explicit error on unsupported versions of PSCore and document it in ReadMe as well #1049

Merged

Conversation

bergmeister
Copy link
Collaborator

PR Summary

Closes #1042 by giving an explicit error on unsupported versions of pscore and document it. It is already documented in the release notes (and the release blog post)
The reason for that is the reference to SMA (which cannot be lower because the 6.0.0 and 6.0.1 NuGet packages had bugs in them that made them not usable for PSSA.

PR Checklist

Note: Tick the boxes below that apply to this pull request by putting an x between the square brackets. Please mark anything not applicable to this PR NA.

  • PR has a meaningful title
    • Use the present tense and imperative mood when describing your changes
  • Summarized changes
  • User facing documentation needed
  • Change is not breaking
  • NA Make sure you've added a new test if existing tests do not effectively test the code changed
  • This PR is ready to merge and is not work in progress
    • If the PR is work in progress, please add the prefix WIP: to the beginning of the title and remove the prefix when the PR is ready

@bergmeister bergmeister merged commit 5b4bacb into PowerShell:development Aug 20, 2018
bergmeister added a commit to bergmeister/PSScriptAnalyzer that referenced this pull request Mar 22, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1.17.1 contains no ExportedCommands
2 participants