-
Notifications
You must be signed in to change notification settings - Fork 382
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Remove redundant/outdated build scripts and cleanup #1011
Remove redundant/outdated build scripts and cleanup #1011
Conversation
…nmaintained code switches
This reverts commit 0378f8d.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
other than the JSON thing, this looks fine
@@ -0,0 +1,8 @@ | |||
{ | |||
// See http://go.microsoft.com/fwlink/?LinkId=827846 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I didn't think that comments were allowed in JSON
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Well, per JSON standard, you are right but it's no problem for VSCode, similar comments are also in the .vscode folder of the PowerShell Core repo
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
ok!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
other than the JSON thing, this looks fine
PR Summary
PSPossibleIncorrectComparisonWithNull
andPSAvoidTrailingWhitespace
PR Checklist
Note: Tick the boxes below that apply to this pull request by putting an
x
between the square brackets. Please mark anything not applicable to this PRNA
.WIP:
to the beginning of the title and remove the prefix when the PR is ready