Make new error messages into resource strings

PowerShell · Feb 14, 2019 · 2ff8b5d · 2ff8b5d
1 parent cc3f16c
commit 2ff8b5d
Show file tree

Hide file tree

Showing 4 changed files with 47 additions and 11 deletions.
diff --git a/Rules/CompatibilityRules/UseCompatibleCommands.cs b/Rules/CompatibilityRules/UseCompatibleCommands.cs
@@ -231,7 +231,7 @@ public static CommandCompatibilityDiagnostic Create(
         {
             string message = string.Format(
                 CultureInfo.CurrentCulture,
-                Strings.UseCompatibleCommandsError,
+                Strings.UseCompatibleCommandsCommandError,
                 commandName,
                 platform.PowerShell.Version,
                 platform.OperatingSystem.FriendlyName);
@@ -269,7 +269,7 @@ public static CommandCompatibilityDiagnostic CreateForParameter(
         {
             string message = string.Format(
                 CultureInfo.CurrentCulture,
-                "The parameter '{0}' is not available for command '{1}' in PowerShell '{2}' on '{3}'",
+                Strings.UseCompatibleCommandsParameterError,
                 parameterName,
                 commandName,
                 platform.PowerShell.Version,

diff --git a/Rules/CompatibilityRules/UseCompatibleTypes.cs b/Rules/CompatibilityRules/UseCompatibleTypes.cs
@@ -603,7 +603,7 @@ public static TypeCompatibilityDiagnostic CreateForStaticMethod(
         {
             string message = String.Format(
                 CultureInfo.CurrentCulture,
-                "The method '{0}' on type '{1}' is not available in PowerShell {2} on platform '{3}'",
+                Strings.UseCompatibleTypesMethodError,
                 methodName,
                 typeName,
                 platform.PowerShell.Version,
@@ -645,7 +645,7 @@ public static TypeCompatibilityDiagnostic CreateForStaticProperty(
         {
             string message = String.Format(
                 CultureInfo.CurrentCulture,
-                "The member '{0}' on type '{1}' is not available in PowerShell {2} on platform '{3}'",
+                Strings.UseCompatibleTypesMemberError,
                 propertyName,
                 typeName,
                 platform.PowerShell.Version,

diff --git a/Rules/Strings.Designer.cs b/Rules/Strings.Designer.cs
diff --git a/Rules/Strings.resx b/Rules/Strings.resx
@@ -819,9 +819,12 @@
   <data name="UseCompatibleCommandsDescription" xml:space="preserve">
     <value>Use commands compatible with the given PowerShell version and operating system</value>
   </data>
-  <data name="UseCompatibleCommandsError" xml:space="preserve">
+  <data name="UseCompatibleCommandsCommandError" xml:space="preserve">
     <value>The command '{0}' is not available by default in PowerShell version '{1}' on platform '{2}'</value>
   </data>
+  <data name="UseCompatibleCommandsParameterError" xml:space="preserve">
+    <value>The parameter '{0}' is not available for command '{1}' by default in PowerShell version '{2}' on platform '{3}'</value>
+  </data>
   <data name="UseCompatibleTypesName" xml:space="preserve">
     <value>UseCompatibleTypes</value>
   </data>
@@ -834,6 +837,12 @@
   <data name="UseCompatibleTypesTypeError" xml:space="preserve">
     <value>The type '{0}' is not available by default in PowerShell version '{1}' on platform '{2}'</value>
   </data>
+  <data name="UseCompatibleTypesMethodError" xml:space="preserve">
+    <value>The method '{0}' is not available on type '{1}' by default in PowerShell version '{2}' on platform '{3}'</value>
+  </data>
+  <data name="UseCompatibleTypesMemberError" xml:space="preserve">
+    <value>The member '{0}' is not available on type '{1}' by default in PowerShell version '{2}' on platform '{3}'</value>
+  </data>
   <data name="UseCompatibleSyntaxName" xml:space="preserve">
     <value>UseCompatibleSyntax</value>
   </data>