PSDscResources: Update LICENSE file to match the Microsoft Open Source Team standard. Fixes Issue #120 #121
Conversation
Codecov Report
@@ Coverage Diff @@
## dev #121 +/- ##
===================================
Coverage 83% 83%
===================================
Files 19 19
Lines 2760 2760
Branches 4 4
===================================
Hits 2305 2305
Misses 451 451
Partials 4 4 |
|
Labeling this pull request (PR) as abandoned since it has gone 14 days or more since the last update. An abandoned PR can be continued by another contributor. The abandoned label will be removed if work on this PR is taken up again. |
There was a problem hiding this comment.
Reviewed 2 of 2 files at r1.
Reviewable status: all files reviewed, 1 unresolved discussion (waiting on @timhaintz)
README.md, line 581 at r1 (raw file):
* Update LICENSE file to match the Microsoft Open Source Team standard. * Fixes [Issue #120](https://github.com/PowerShell/PSDscResources/issues/120)
Can you connect the "Fixes ..." to the previous line entry: E.g.
* Update LICENSE file to match the Microsoft Open Source Team standard - Fixes [Issue #120](https://github.com/PowerShell/PSDscResources/issues/120)
There was a problem hiding this comment.
This isn't abandoned 😁
Reviewable status: all files reviewed, 1 unresolved discussion (waiting on @timhaintz)
|
Thanks @PlagueHO will fix it today. |
|
Cheers @timhaintz - not sure when we will be able to get a merge, but hopefully not too long. |
There was a problem hiding this comment.
Reviewable status: 1 of 2 files reviewed, 1 unresolved discussion (waiting on @PlagueHO)
README.md, line 581 at r1 (raw file):
Previously, PlagueHO (Daniel Scott-Raynsford) wrote…
Can you connect the "Fixes ..." to the previous line entry: E.g.
* Update LICENSE file to match the Microsoft Open Source Team standard - Fixes [Issue #120](https://github.com/PowerShell/PSDscResources/issues/120)
Updated as requested @PlagueHO , let me know if you would like me to update anything else. Thanks, Tim.
There was a problem hiding this comment.
Reviewable status: 1 of 2 files reviewed, 1 unresolved discussion (waiting on @PlagueHO)
README.md, line 581 at r1 (raw file):
Previously, timhaintz wrote…
Updated as requested @PlagueHO , let me know if you would like me to update anything else. Thanks, Tim.
Done.
There was a problem hiding this comment.
Reviewed 1 of 1 files at r2.
Reviewable status: all files reviewed, 1 unresolved discussion (waiting on @timhaintz)
README.md, line 581 at r1 (raw file):
Previously, timhaintz wrote…
Done.
Thanks @timhaintz - can you make one minor change to this: Reduce the line length so that it isn't so long.
E.g.
* Update LICENSE file to match the Microsoft Open Source Team
standard - Fixes [Issue #120](https://github.com/PowerShell/PSDscResources/issues/120)
There was a problem hiding this comment.
Just a minor tweak to the line length and we'll get this one completed 😁
Reviewable status: all files reviewed, 1 unresolved discussion (waiting on @timhaintz)
|
Ah, gets me every time! Sorry @PlagueHO . Have updated as requested above, the second line is 89 characters long, is that too long? Pushing now. Thanks, Tim. |
|
@PlagueHO just noticed appveyor failed. Do you want me to pull from upstream again or is it something you can resolve? |
|
@PlagueHO I've merged the upstream changes. Waiting for tests to run. Thanks, Tim. |
There was a problem hiding this comment.
Reviewable status: 1 of 2 files reviewed, 1 unresolved discussion (waiting on @PlagueHO)
There was a problem hiding this comment.
Thanks @timhaintz
Reviewed 1 of 2 files at r1, 1 of 1 files at r5.
Reviewable status:complete! all files reviewed, all discussions resolved
|
Thanks @PlagueHO |
Fixes Issue #120
README.md updated.
This change is