add methods column to table view #314
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
SteveL-MSFT
requested changes
Feb 10, 2024
dsc/src/subcommand.rs
Outdated
| } | ||
|
|
||
| methods = "get".to_string(); |
There was a problem hiding this comment.
Should probably still keep a check here for get as the discussion of whether it must be mandatory might change in the future.
There was a problem hiding this comment.
That makes sense - what do you suggest checking?
The get field of the struct isn't optional so the is_some() check doesn't apply.
SteveL-MSFT
approved these changes
Feb 20, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR Summary
Methodsto table view fordsc resource list#309PR Context