Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Document dependsOn update #185

Conversation

michaeltlombardi
Copy link
Collaborator

PR Summary

This change:

  • Updates the schema and documentation for instance names to clarify that they must be non-empty strings containing only letters, numbers, and spaces.
  • Updates the schema and documentation for the dependsOn property to use the new resourceId() function syntax as added in Dependson #175.
  • Regenerates the schemas with the updated definitions for 2023/08
  • Updates the YAML metadata blocks in the reference documentation to match the updated blocks on the learn platform.

PR Context

Prior to this change, the schema for the dependsOn keyword used the PSDSC syntax and the schema for instance names allowed arbitrary strings.

For now, this change does not define new reference documentation for the configuration functions. When more configuration functions are added, we can define a separate set of reference documentation for those functions.

> provider or group instance.
>
> If a top-level instance depends on a nested instance, use the `resourceId()` function to lookup
> the instance of the provider or group containing the dependency instance instead.
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Does it make sense to say that if there is a need to depend on something deeply nested, you can use grouping to achieve the same effect. An example would probably be best.

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you share a pseudo-example of what you mean? I can convert this into a full example afterward, though that may better belong in the eventual conceptual article for managing dependencies in configuration documents.

Copy link
Member

@SteveL-MSFT SteveL-MSFT left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

minor feedback

Prior to this change, the schema for the `dependsOn` keyword used the PSDSC
syntax and the schema for instance names allowed arbitrary strings.

This change:

- Updates the schema and documentation for instance names to clarify that
  they must be non-empty strings containing only letters, numbers, and
  spaces.
- Updates the schema and documentation for the `dependsOn` property to
  use the new `resourceId()` function syntax as added in PowerShell#175.

For now, this change does not define new reference documentation for the
configuration functions. When more configuration functions are added, we
can define a separate set of reference documentation for those functions.
This change regenerates the canonical schemas based on the changes to
the schemas for the `dependsOn` keyword and instance names.
This change updates the formatting for the YAML metadata blocks in
the reference documentation to match the formatting used on Learn.

The prior formatting rendered incorrectly on the platform. The updated
formatting renders correctly and adheres to the developing style guidance
for using YAML metadata in this way.
@michaeltlombardi michaeltlombardi force-pushed the maint/main/document-dependsOn-update branch from a43beb8 to 467bc33 Compare September 5, 2023 14:49
@michaeltlombardi michaeltlombardi changed the title Maint/main/document depends on update Document dependsOn update Sep 5, 2023
@SteveL-MSFT SteveL-MSFT merged commit 50f9908 into PowerShell:main Sep 5, 2023
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants