Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ScheduledTask: IdleWaitTimeout returned from Get-TargetResource always null #186

Closed
djwork opened this issue Sep 30, 2018 · 5 comments
Closed
Labels
bug The issue is a bug.

Comments

@djwork
Copy link
Contributor

djwork commented Sep 30, 2018

Background: Working on a fork to implement run as NETWORK SERVICE and I was getting Test-TargetResource invalidly returning false. Traced it to this issue among others.

The bug is caused by the following line in Get-TargetResource:
IdleWaitTimeout = ConvertTo-TimeSpanStringFromScheduledTaskString -TimeSpan $settings.IdleSettings.IdleWaitTimeout
The problem is IdleSettings object does not have a IdleWaitTimeout property, but it does have a WaitTimeout property.

I have implemented a fix in my fork, creating this issue to reference in CHANGELOG.md

@djwork
Copy link
Contributor Author

djwork commented Oct 1, 2018

See my pull request:
#187

@PlagueHO PlagueHO added bug The issue is a bug. in progress The issue is being actively worked on by someone. labels Oct 1, 2018
@PlagueHO
Copy link
Member

PlagueHO commented Oct 1, 2018

Thank you @djwork - look forward to merging this. Will review once the merge conflicts are sorted.

@djwork
Copy link
Contributor Author

djwork commented Oct 1, 2018

@PlagueHO I rebased off of the dev branch, not sure if I did it correctly, I am a git novice

@djwork
Copy link
Contributor Author

djwork commented Oct 3, 2018

New pull request:
#192

@djwork
Copy link
Contributor Author

djwork commented Apr 8, 2019

The fix has been merged into the dev branch and is awaiting release

@djwork djwork closed this as completed Apr 8, 2019
@kwirkykat kwirkykat removed the in progress The issue is being actively worked on by someone. label Apr 8, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug The issue is a bug.
Projects
None yet
Development

No branches or pull requests

3 participants