Update ShouldProcess for PowerArubaSW

[blurpiflurp]

Hi!

This proposed change adds support for -confirm:$false instead of using internal logic and "-noconfirm" flags.

However you might want to work a bit with the message displayed if its not to your liking.

PS > Remove-ArubaSWVLAN -id 10

Confirm
Are you sure you want to perform this action?
Performing the operation "Remove VLAN" on target "Vlan ID 10".
[Y] Yes  [A] Yes to All  [N] No  [L] No to All  [S] Suspend  [?] Help (default is "Y"): n
PS > Remove-ArubaSWVLAN -id 10 -Confirm:$false
PS >

[blurpiflurp]

I've also updated the vlan tests and also the help section of the cmdlet.

[alagoutte]

Hi,

yes, i need to use ShouldProcess for all (remove) command !

What do you have make change on Connection.ps1 ?

[blurpiflurp]

It should have been a separate pull.

I changed it so it uses write-verbose if you specify -verbose instead of having “noverbose” flag on it.

And I also added so the name of the switch is added to the connection so if for instance you have 100 switches you can do
$arubaswitchcollection|where name -eq 'switch1' or when adding vlans you get which switch you're adding it to.

I've made a small function that imports vlans from an excel file and adds them to a collection of switches. When doing this its preferable that errors etc refers to a specific switch. Or for instance see this code that I use for cleaning up a lab I was doing.

function Remove-ArubaLabVLAN {
    [CmdletBinding(SupportsShouldProcess, ConfirmImpact = 'Low')]
    Param(
        [Parameter (Mandatory = $False)]
        [ValidateNotNullOrEmpty()]
        [PSObject]$connection = $DefaultArubaSWConnection
    )
    Begin {
    }

    Process {
        if ($null -eq $connection -or [string]::IsNullOrEmpty($connection)) {
            write-error "No ArubaSwitch specified"
            return
        }
        if ($connection.count -gt 1 -and $connection.GetType().basetype.name -eq 'Array') {
            $buff = foreach ($aconn in $connection) {
                Remove-ArubaLabVLAN -connection $aconn
            }
            $buff
        } else {
            Write-Progress -activity "Remove Vlan on $($connection.Name)" -id 4 -percentcomplete 0
            $tot = 8
            foreach ($id in @(601..608)) {
                $count = $id-600
                $uri = "rest/v4/vlans/${id}"
                $target = "{0} on {1}" -f $id, $connection.Name
                if ($PSCmdlet.ShouldProcess($target, "Remove VLAN")) {
                    Write-Progress -activity "Remove Vlan on $($connection.Name)" -status $id -id 4 -percentcomplete $($count/$tot*100)
                    $null = Invoke-ArubaSWWebRequest -method "DELETE" -uri $uri -connection $connection
                    Write-Progress -activity "Remove Vlan on $($connection.name)" -id 4 -percentcomplete $($count/$tot*100)
                }
            }
        }
    }

    End {
    }
}

[alagoutte]

It should have been a separate pull.
Yes please !

I changed it so it uses write-verbose if you specify -verbose instead of having “noverbose” flag on it.

Yes, it is not a good idea to have noverbose flag...

And I also added so the name of the switch is added to the connection so if for instance you have 100 switches you can do
$arubaswitchcollection|where name -eq 'switch1' or when adding vlans you get which switch you're adding it to.

I've made a small function that imports vlans from an excel file and adds them to a collection of switches. When doing this its preferable that errors etc refers to a specific switch. Or for instance see this code that I use for cleaning up a lab I was doing.

function Remove-ArubaLabVLAN {
    [CmdletBinding(SupportsShouldProcess, ConfirmImpact = 'Low')]
    Param(
        [Parameter (Mandatory = $False)]
        [ValidateNotNullOrEmpty()]
        [PSObject]$connection = $DefaultArubaSWConnection
    )
    Begin {
    }

    Process {
        if ($null -eq $connection -or [string]::IsNullOrEmpty($connection)) {
            write-error "No ArubaSwitch specified"
            return
        }
        if ($connection.count -gt 1 -and $connection.GetType().basetype.name -eq 'Array') {
            $buff = foreach ($aconn in $connection) {
                Remove-ArubaLabVLAN -connection $aconn
            }
            $buff
        } else {
            Write-Progress -activity "Remove Vlan on $($connection.Name)" -id 4 -percentcomplete 0
            $tot = 8
            foreach ($id in @(601..608)) {
                $count = $id-600
                $uri = "rest/v4/vlans/${id}"
                $target = "{0} on {1}" -f $id, $connection.Name
                if ($PSCmdlet.ShouldProcess($target, "Remove VLAN")) {
                    Write-Progress -activity "Remove Vlan on $($connection.Name)" -status $id -id 4 -percentcomplete $($count/$tot*100)
                    $null = Invoke-ArubaSWWebRequest -method "DELETE" -uri $uri -connection $connection
                    Write-Progress -activity "Remove Vlan on $($connection.name)" -id 4 -percentcomplete $($count/$tot*100)
                }
            }
        }
    }

    End {
    }
}

ok interesting...

[alagoutte]

can you split your patch (and make a another PR for connection stuff ?)

[blurpiflurp]

Yeah I'm working on a larger patch for more stuff so will do in a couple of days and we will see what you approve :)