Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Updated list. #5

Merged
merged 3 commits into from
Jul 4, 2015
Merged

Updated list. #5

merged 3 commits into from
Jul 4, 2015

Conversation

Crayder
Copy link
Collaborator

@Crayder Crayder commented Jul 3, 2015

I haven't actually tested, but this is a hell of a bit to test. I don't know what has been added (or if anything has been removed) exactly so I'll see the github comparison.

I haven't actually tested, but this is a hell of a bit to test. I don't know what has been added (or if anything has been removed) exactly so I'll see the github comparison.
@Crayder
Copy link
Collaborator Author

Crayder commented Jul 3, 2015

Another thing, loaded maps from old versions will not be compatible (i.e. if textures were set). I suggest you add a server version variable to saved maps. Then when a map is loaded you could check the map's version and update it accordingly. For now though you'll need a script to convert old versions to this new list. because the texture reference IDs will be off.

EDIT: I decided to test before I passed out, everything works fine (except loading maps of course, as explained above)! There may be a few useless textures, such as the "signsurf, sign" texture (which could be handy for texturing clear spaces instead of using a transparent color, I guess). I went through the last 1500 textures using the /mtextures command, and that was the only 'useless' texture I found.

@Pottus
Copy link
Owner

Pottus commented Jul 3, 2015

Hmmm, the SA-MP textures need to be appended to the end of the list I have for compatibility. If I merge this everyone's map will have problems.

@Crayder
Copy link
Collaborator Author

Crayder commented Jul 3, 2015

Got it. They are now appended to the end of your original list.

I used SQL with unique texture name, inserted all of your original list, followed my instructions above but only for SAMP img/ide, inserted that output to the database, and here we are.

@Crayder
Copy link
Collaborator Author

Crayder commented Jul 3, 2015

Wait, don't use that yet. I forgot to UPPER->lower.

@Crayder
Copy link
Collaborator Author

Crayder commented Jul 3, 2015

Ok, well I've noticed a problem with YOUR list. You have allowed duplicates in your list because of the case sensitivity. My list takes out your duplicates so it'll never match up.

Pottus added a commit that referenced this pull request Jul 4, 2015
@Pottus Pottus merged commit 9a9d188 into Pottus:master Jul 4, 2015
@Crayder
Copy link
Collaborator Author

Crayder commented Jul 4, 2015

You have read my last comment before merging, right? Since the SQL method I used removed your duplicates only about the first 1500 indexes are going to be correct, you had at least 10 duplicates.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants