-
Notifications
You must be signed in to change notification settings - Fork 1.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
#4050 insights layouts & misc improvements #4306
Conversation
04f8676
to
8381fe1
Compare
frontend/src/scenes/insights/InsightTabs/SessionTabHorizontal.tsx
Outdated
Show resolved
Hide resolved
frontend/src/scenes/insights/InsightTabs/RetentionTabHorizontal.tsx
Outdated
Show resolved
Hide resolved
frontend/src/scenes/insights/InsightTabs/RetentionTabHorizontal.tsx
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!! Really tiny bits of feedback, mostly copy suggestions. 🚢
Thanks for the quick review here @samwinslow! Re retention filters, if I remember correctly, there was a backend limitation for this that required use of actions? I believe it was due to computations on-the-fly timing out in PostHog. CC @EDsCODE |
Merging as failing checks are unrelated. |
Changes
This PR continues our saga to improve the query experience from #4050; particularly builds up on #4296.
Checklist