Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix date range component in insights #4248

Merged
merged 4 commits into from
May 7, 2021
Merged

Fix date range component in insights #4248

merged 4 commits into from
May 7, 2021

Conversation

paolodamico
Copy link
Contributor

Changes

A recent refactor (maybe #4233) broke down the date range selector in insights because we accidentally linked a different component with the same name. To avoid this happening in the future, I've also renamed the offending component to avoid any further confusion.

Checklist

  • All querysets/queries filter by Organization, by Team, and by User
  • Django backend tests
  • Jest frontend tests
  • Cypress end-to-end tests
  • Migrations are safe to run at scale (e.g. PostHog Cloud) – present proof if not obvious

@paolodamico paolodamico added bug Something isn't working right P0 Critical, breaking issue (page crash, missing functionality) labels May 7, 2021
@timgl timgl temporarily deployed to posthog-pr-4248 May 7, 2021 01:16 Inactive
@paolodamico paolodamico merged commit da040fc into master May 7, 2021
@paolodamico paolodamico deleted the fix-daterange branch May 7, 2021 01:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working right P0 Critical, breaking issue (page crash, missing functionality)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants