Dashboard item description (1/2)

[liyiy]

Changes

(1/2) Updates for dashboard item editing on #3551

• Follow up PR (2/2) will include
  • allowing dashboard item title to be edited
  • some more style fixes
  • e2es

Checklist

• All querysets/queries filter by Organization, by Team, and by User
• Django backend tests
• Jest frontend tests
• Cypress end-to-end tests
• Migrations are safe to run at scale (e.g. PostHog Cloud) – present proof if not obvious

[liyiy]

There's a lot of the same code between the dashboard description edit and dashboard item description edit, maybe worth going over at a later time to see which parts to consolidate ^_^

[liyiy]

confused with prettier failure that doesn't show what the error is in the Dashboard.scss file 😦

[paolodamico]

Looking pretty good!! Reviewed this from a UX perspective,

1. I think we should keep the same consistent behavior for editing as we do for dashboards (see below). Clicking to edit instead of the button, close if you click outside, cmd/cntrl + enter to submit.
2. I think dashboard item might be confusing. Maybe dashboard insight?
3. Related to the above the placeholder text should be: "Add a description for this dashboard insight..."
4. The description should not be muted if it's set (show in default text color). Probably worth having it the same font size as the rest (unsure, let's try it out).
5. You should be able to edit the item's description from the dashboard page.

[liyiy]

@macobo I addressed most of the concerns on @paolodamico's comment but in favor of keeping this PR from spiraling, I will address everything else in the second PR of this (editing dashboard insight description on the dashboards page)