Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Horizontal query UI top-level elements (4050) #4217

Merged
merged 3 commits into from
May 6, 2021

Conversation

samwinslow
Copy link
Contributor

@samwinslow samwinslow commented May 5, 2021

Changes

Adds to #4050. Here's the current state of the new filter UI.

Screen Shot 2021-05-05 at 9 55 13 AM

Screen Shot 2021-05-05 at 9 54 53 AM

Keeping this PR small — what still needs to be done:

  • Filter button at right, next to delete (change delete to red color?)
  • Flatten the local filters UI (don't use the mini Property/Cohort modal and blue open button); also hide this behind same feature flag
  • Move global filters, breakdowns to right.

NB: Set feature flag 4050-query-ui-optB to view.

Checklist

  • All querysets/queries filter by Organization, by Team, and by User
  • Django backend tests
  • Jest frontend tests
  • Cypress end-to-end tests
  • Migrations are safe to run at scale (e.g. PostHog Cloud) – present proof if not obvious

@timgl timgl temporarily deployed to posthog-pr-4217 May 5, 2021 14:04 Inactive
@liyiy
Copy link
Contributor

liyiy commented May 5, 2021

How come I can't see this view on the deploy? Do I have to do something specific? 😮

@samwinslow
Copy link
Contributor Author

How come I can't see this view on the deploy? Do I have to do something specific? 😮

Updated description to mention feature flag 4050-query-ui-optB 😄

Copy link
Contributor

@paolodamico paolodamico left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

let's get this in and continue improving from here! there are some fixes/improvements to be made, but we can work them out in a separate PR, great stuff!

@samwinslow samwinslow merged commit ed9dc43 into master May 6, 2021
@samwinslow samwinslow deleted the 4050-query-ui-optB-main branch May 6, 2021 00:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants