Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add scroll to dashboard fullscreen/presentation mode #4039

Merged
merged 2 commits into from
Apr 20, 2021
Merged

Add scroll to dashboard fullscreen/presentation mode #4039

merged 2 commits into from
Apr 20, 2021

Conversation

liyiy
Copy link
Contributor

@liyiy liyiy commented Apr 19, 2021

Changes

add and remove scroll for dashboard fullscreen mode

Screen.Recording.2021-04-19.at.5.22.32.PM.mov

Checklist

  • All querysets/queries filter by Organization, by Team, and by User
  • Django backend tests
  • Jest frontend tests
  • Cypress end-to-end tests
  • Migrations are safe to run at scale (e.g. PostHog Cloud) – present proof if not obvious

@timgl timgl temporarily deployed to posthog-pr-4039 April 19, 2021 21:28 Inactive
samwinslow
samwinslow reviewed Apr 19, 2021
View reviewed changes
frontend/src/global.scss Outdated
@@ -604,3 +604,7 @@ code.code {
font-size: 1rem;
}
}

.fullscreen-scroll {
overflow-y: scroll;
Copy link
Contributor

@samwinslow samwinslow Apr 19, 2021 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nitpick but maybe overflow-y: auto would look better here. See discussion on a similar issue #3967

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

good catch, thanks!

@timgl timgl temporarily deployed to posthog-pr-4039 April 20, 2021 13:41 Inactive
@liyiy liyiy requested a review from samwinslow April 20, 2021 14:02
@liyiy liyiy merged commit 1e55504 into master Apr 20, 2021
@liyiy liyiy deleted the dashboard-fullscreen-scroll branch April 20, 2021 15:51
@liyiy liyiy added the feature/dashboards Feature Tag: Dashboards label Apr 20, 2021
@liyiy liyiy linked an issue Apr 20, 2021 that may be closed by this pull request
[Epic] Dashboards UX improvement #3547
Closed
7 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@samwinslow samwinslow samwinslow approved these changes

@EDsCODE EDsCODE Awaiting requested review from EDsCODE

Assignees

@liyiy liyiy

Labels
feature/dashboards Feature Tag: Dashboards
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[Epic] Dashboards UX improvement
3 participants
@liyiy @samwinslow @timgl