-
Notifications
You must be signed in to change notification settings - Fork 1.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Description & tagging on dashboards #3756
Conversation
@jamesefhawkins this seems like a feature geared towards collaboration, should we make it a premium feature? I'm worried it's just a tiny thing that will cause more complexity (UX & code) than what is worth. Thoughts? |
UX question for @corywatilo, opted for allowing direct changes to tags without entering edit mode, wdyt? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Added some minor nits, did not go through the whole flow though
I definitely think this has to be paid so that we can keep giving a ton of functionality to free users whilst building a real business at the same time. Collaboration-related features like this definitely aren't needed for 1 person, but for a team of more than a couple (thus a company, with money involved) are really important. I can see how this is annoying code-wise, but this will happen repeatedly, so we need to find a way to do easily if we can? |
Makes sense @jamesefhawkins, will make it a paid feature, we do have a way to handle this that is fairly simple to implement, it's just something we'll have to mind when we make changes to this feature. |
Changes
This PR adds more stuff from #3344 & #3551. Please view original issues for motivation and context.
Checklist