Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Description & tagging on dashboards #3756

Merged
merged 15 commits into from
Mar 27, 2021
Merged

Conversation

paolodamico
Copy link
Contributor

Changes

This PR adds more stuff from #3344 & #3551. Please view original issues for motivation and context.

  • Allows adding descriptions to dashboards to better provide context on each dashboard.

  • Allows tagging dashboards for easier organization (includes autocomplete, duplicates prevention, loading states, ...).
    image
  • Tags are shown on dashboard list too and can be filtered on.

  • Descriptions are shown when publicly sharing a dashboard.
  • Empty state when you don't have any tags registered.
  • Adjusts relevant instrumentation accordingly.

Checklist

  • All querysets/queries filter by Organization, by Team, and by User
  • Django backend tests
  • Jest frontend tests
  • Cypress end-to-end tests

@paolodamico
Copy link
Contributor Author

@jamesefhawkins this seems like a feature geared towards collaboration, should we make it a premium feature? I'm worried it's just a tiny thing that will cause more complexity (UX & code) than what is worth. Thoughts?

@paolodamico
Copy link
Contributor Author

paolodamico commented Mar 26, 2021

UX question for @corywatilo, opted for allowing direct changes to tags without entering edit mode, wdyt?

@timgl timgl temporarily deployed to posthog-pr-3756 March 26, 2021 01:11 Inactive
Copy link
Contributor

@macobo macobo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Added some minor nits, did not go through the whole flow though

@jamesefhawkins
Copy link
Collaborator

@jamesefhawkins this seems like a feature geared towards collaboration, should we make it a premium feature? I'm worried it's just a tiny thing that will cause more complexity (UX & code) than what is worth. Thoughts?

I definitely think this has to be paid so that we can keep giving a ton of functionality to free users whilst building a real business at the same time. Collaboration-related features like this definitely aren't needed for 1 person, but for a team of more than a couple (thus a company, with money involved) are really important.

I can see how this is annoying code-wise, but this will happen repeatedly, so we need to find a way to do easily if we can?

@paolodamico
Copy link
Contributor Author

Makes sense @jamesefhawkins, will make it a paid feature, we do have a way to handle this that is fairly simple to implement, it's just something we'll have to mind when we make changes to this feature.

@timgl timgl temporarily deployed to posthog-pr-3756 March 26, 2021 19:53 Inactive
@timgl timgl temporarily deployed to posthog-pr-3756 March 26, 2021 19:54 Inactive
@timgl timgl temporarily deployed to posthog-pr-3756 March 26, 2021 20:17 Inactive
@paolodamico paolodamico merged commit da61c55 into master Mar 27, 2021
@paolodamico paolodamico deleted the dashboard-description-tagging branch March 27, 2021 00:38
@Twixes Twixes added the highlight ⭐ Release highlight label Apr 8, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
highlight ⭐ Release highlight
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants