Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(flags): Set up initial UI-reorganization for feature management #26363

Draft
wants to merge 5 commits into
base: master
Choose a base branch
from

Conversation

havenbarnes
Copy link
Contributor

@havenbarnes havenbarnes commented Nov 22, 2024

Problem

Initial setup for: #25938

Right now this is just a UI re-organization and does not have any functional changes on the sub-pages themselves. The next step is to customize the Experiments tab to only show relevant items, recall from RFC "The "Experiments" section will be subset of all the experiments we have that map to features"

Changes

Screenshot 2024-11-22 at 1 28 01 PM Screenshot 2024-11-22 at 1 28 08 PM Screenshot 2024-11-22 at 1 28 15 PM

👉 Stay up-to-date with PostHog coding conventions for a smoother review.

Does this work well for both Cloud and self-hosted?

Yes

How did you test this code?

  • Ran locally
  • Will add Cypress tests validating navigation after creating, editing items in each section

Copy link
Contributor

github-actions bot commented Nov 22, 2024

Size Change: +107 B (+0.01%)

Total Size: 1.16 MB

ℹ️ View Unchanged
Filename Size Change
frontend/dist/toolbar.js 1.16 MB +107 B (+0.01%)

compressed-size-action

@raquelmsmith
Copy link
Member

I think the left nav item should be "Features" and go at the top under Notebooks

I was also thinking that Features would be a list of features - eg "new friend inviter" or "document creator" - these are not features we offer in posthog, but instead a thing that someone makes to track their own feature development and rollout.

So each "feature" should have a section for "linked flags" which is the flags that someone has said are related to the feature. Same for experiments.

We can chat through this on monday if you'd like!

import { Spinner } from 'lib/lemon-ui/Spinner'
import { lazy, Suspense } from 'react'

const EarlyAccessFeatures = lazy(() =>
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

note for reviewing later: these lazy imports are working well in local dev, but it is unprecedented in the app. Check to make sure there isn't some reason for not using it before. If so, it's a superfluous optimization anyway, but nice for speedy loads

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants