feat(max): Replace reasoning points with generation progress #26346
+312
−202
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Size Change: +1 B (0%) Total Size: 1.16 MB ℹ️ View Unchanged
|
📸 UI snapshots have been updated10 snapshot changes in total. 0 added, 10 modified, 0 deleted:
Triggered by this commit. |
📸 UI snapshots have been updated1 snapshot changes in total. 0 added, 1 modified, 0 deleted:
Triggered by this commit. |
📸 UI snapshots have been updated1 snapshot changes in total. 0 added, 1 modified, 0 deleted:
Triggered by this commit. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem
There was no feedback about the AI assistant's progress.
Changes
We now send a
reasoningtype message every time a preparation node starts running.I spent quite a bit of time thinking how to make the assistant experience feel assistant-like while showing its thinking. We really were missing personality in it – it felt like some unknown entity thinking, not Max the Hedgehog thinking.
So this also features a slight redesign of the thread UI. Human questions now show ares shown as chat messages, there are avatars for both the user and Max, and message boxes are generously rounded for a friendlier feel:
Screen.Recording.2024-11-21.at.22.15.28.mov
The only problem is that the steps take quite a long time, planning in particular – but that's a matter for a separate PR.