Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(insights): add missing filter response for StickinessQueryRunner #24199

Closed
wants to merge 1 commit into from
Closed

feat(insights): add missing filter response for StickinessQueryRunner #24199

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
9 changes: 3 additions & 6 deletions frontend/src/scenes/insights/InsightTooltip/InsightTooltip.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -75,6 +75,7 @@ export function InsightTooltip({
date,
timezone = 'UTC',
seriesData = [],
title: _title,
altTitle,
altRightTitle,
renderSeries,
Expand All @@ -99,13 +100,9 @@ export function InsightTooltip({

const { formatPropertyValueForDisplay } = useValues(propertyDefinitionsModel)

const title: ReactNode | null =
const title: ReactNode =
getTooltipTitle(seriesData, altTitle, date) ||
(date
? `${getFormattedDate(date, seriesData?.[0]?.filter?.interval)} (${
timezone ? shortTimeZone(timezone) : 'UTC'
})`
: null)
`${getFormattedDate(_title)} ${timezone ? shortTimeZone(timezone) : 'UTC'}`
const rightTitle: ReactNode | null = getTooltipTitle(seriesData, altRightTitle, date) || null

if (itemizeEntitiesAsColumns) {
Expand Down
1 change: 1 addition & 0 deletions frontend/src/scenes/insights/InsightTooltip/insightTooltipUtils.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -59,6 +59,7 @@ export interface InsightTooltipProps extends Omit<TooltipConfig, 'renderSeries'
breakdownFilter?: BreakdownFilter | undefined | null
groupTypeLabel?: string
timezone?: string | null
title: string
}

export const COL_CUTOFF = 4
Expand Down
1 change: 1 addition & 0 deletions frontend/src/scenes/insights/views/LineGraph/LineGraph.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -495,6 +495,7 @@ export function LineGraph_({
tooltipRoot.render(
<InsightTooltip
date={dataset?.days?.[tooltip.dataPoints?.[0]?.dataIndex]}
title={tooltip.title[0]}
timezone={timezone}
seriesData={seriesData}
breakdownFilter={breakdownFilter}
Expand Down
Loading