fix: add copy for the survey wait period as part of the display conditions summary #22532
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Size Change: +60 B (+0.01%) Total Size: 1.03 MB ℹ️ View Unchanged
|
neilkakkar
reviewed
May 28, 2024
| <div className="flex-row"> | ||
| <span>Wait period after seeing survey:</span>{' '} | ||
| <span className="simple-tag tag-light-blue text-primary-alt"> | ||
| {survey.conditions.seenSurveyWaitPeriodInDays} days |
There was a problem hiding this comment.
Okay fixed this and fixed the targeting selection option to say "day" if the user selects 1 day
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem
As part of this PR, I made a change to how we show the survey display conditions summary. However, as Neil pointed out, I missed a condition for the waiting period, so it displays nothing in that case.
Changes
Before (buggy behavior)
After (fix)