feat(onboarding): Dark mode #21149
feat(onboarding): Dark mode #21149
Conversation
📸 UI snapshots have been updated30 snapshot changes in total. 0 added, 30 modified, 0 deleted:
Triggered by this commit. |
|
Size Change: -369 B (0%) Total Size: 824 kB ℹ️ View Unchanged
|
📸 UI snapshots have been updated41 snapshot changes in total. 0 added, 41 modified, 0 deleted:
Triggered by this commit. |
@benjackwhite agree with you around the confusing UI but I do think it should be ok it:
I do want to make sure there will be no regression in the UI on these pages before merging. |
@raquelmsmith was the one who raised this before essentially arguing that we should carefully AB test changes to the onboarding flow (but again I defer to you lot to decide 👍 ) |
| userThemeMode: [ | ||
| (s) => [s.user, s.themeFromCookie], | ||
| (user, themeFromCookie): UserTheme => { | ||
| return user?.theme_mode || themeFromCookie || 'light' |
There was a problem hiding this comment.
should be decently easy to set up a flag here I believe. Let's test it because we can, and because colors can have a big impact on signup.
There was a problem hiding this comment.
@Twixes how could we feature flag this just for the auth pages? I can do it if you'd like just needs some hints on where to start.
There was a problem hiding this comment.
There's this setFeatureFlags utility.
Example usage: https://github.com/PostHog/posthog/blob/master/frontend/src/layout/FeaturePreviews/FeaturePreviews.stories.tsx#L33
I haven't actually done this myself so this could be the wrong direction.
There was a problem hiding this comment.
added snapshot is somehow slightly cut off vertically?
There was a problem hiding this comment.
PostHog Cloud logo needs a dark mode version
| @@ -129,7 +129,8 @@ async function expectStoryToMatchSnapshot( | |||
| check = expectStoryToMatchComponentSnapshot | |||
| } | |||
|
|
|||
| await waitForPageReady(page) | |||
| await waitForPageReady(page) | |||
There was a problem hiding this comment.
| await waitForPageReady(page) | |
| await waitForPageReady(page) |
|
This PR hasn't seen activity in a week! Should it be merged, closed, or further worked on? If you want to keep it open, post a comment or remove the |
|
This PR was closed due to lack of activity. Feel free to reopen if it's still relevant. |
Problem
Dark mode is available on the website and in the logged-in part of the app, but not in the glue – login/signup/onboarding pages. Prompted by Zach's question about disabling dark mode UI snapshots, I thought it might be simpler to add the missing support for dark mode instead.
Changes
Bridge pages should now support dark mode. Additionally, this will be synced with posthog.com by default.
Does this work well for both Cloud and self-hosted?
👍
How did you test this code?
UI snapshots