Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: player meta links #19090

Merged
merged 2 commits into from
Dec 5, 2023
Merged

fix: player meta links #19090

merged 2 commits into from
Dec 5, 2023

Conversation

pauldambra
Copy link
Member

@pauldambra pauldambra commented Dec 5, 2023 •
edited
Loading

see #19037

  • Apps don't have URLs so don't link to them - fixes "Replay title (inferred from href) always leads to Recording not found"
  • changing that made me realise that the player meta area generated the property icons itself so I'd missed them in feat: mobile replay preview row #18973

now shows the same icons

full screen

Screenshot 2023-12-05 at 13 31 02

not full screen

Screenshot 2023-12-05 at 13 30 53

@pauldambra pauldambra requested a review from a team December 5, 2023 13:36
@pauldambra pauldambra enabled auto-merge (squash) December 5, 2023 15:19
@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Dec 5, 2023

Size Change: 0 B

Total Size: 1.83 MB

ℹ️ View Unchanged
Filename Size
frontend/dist/toolbar.js 1.83 MB

compressed-size-action

@pauldambra pauldambra merged commit f6eca1e into master Dec 5, 2023
78 checks passed
@pauldambra pauldambra deleted the fix/player-meta branch December 5, 2023 15:31
Twixes pushed a commit that referenced this pull request Dec 6, 2023
@pauldambra @Twixes
fix: player meta links (#19090)
c3aacf7 
* fix: player meta links

* Fix
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@marandaneto marandaneto marandaneto approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@pauldambra @marandaneto