feat: add interaction components to schema #19040
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Size Change: 0 B Total Size: 1.83 MB ℹ️ View Unchanged
|
marandaneto
reviewed
Dec 4, 2023
marandaneto
reviewed
Dec 4, 2023
marandaneto
reviewed
Dec 4, 2023
marandaneto
reviewed
Dec 4, 2023
marandaneto
reviewed
Dec 4, 2023
marandaneto
reviewed
Dec 4, 2023
marandaneto
reviewed
Dec 4, 2023
marandaneto
reviewed
Dec 4, 2023
marandaneto
reviewed
Dec 4, 2023
|
More items to consider:
|
Co-authored-by: Manoel Aranda Neto <[email protected]>
Co-authored-by: Manoel Aranda Neto <[email protected]>
Co-authored-by: Manoel Aranda Neto <[email protected]>
Co-authored-by: Manoel Aranda Neto <[email protected]>
Co-authored-by: Manoel Aranda Neto <[email protected]>
Co-authored-by: Manoel Aranda Neto <[email protected]>
|
copied extra components to #19037 |
pauldambra
commented
Dec 4, 2023
| } | ||
|
|
||
| export type wireframeRadioGroup = wireframeBase & { | ||
| groupName: string |
There was a problem hiding this comment.
Suggested change
| groupName: string | |
| type: 'radio group' |
@marandaneto is there any value to the App to specify this group name? Otherwise I can pass a UUID to all children radios...
There was a problem hiding this comment.
I could set the viewId similarly to how it's generated for any other component, but we don't have such groupName on Android.
There was a problem hiding this comment.
ok, let's leave it out... easier to add than to remove 👍
marandaneto
approved these changes
Dec 5, 2023
Twixes
pushed a commit
that referenced
this pull request
Dec 6, 2023
* feat: add interaction components to schema * expand radio * liek this * Update query snapshots * Update query snapshots * like this * Update ee/frontend/mobile-replay/mobile.types.ts Co-authored-by: Manoel Aranda Neto <[email protected]> * Update ee/frontend/mobile-replay/mobile.types.ts Co-authored-by: Manoel Aranda Neto <[email protected]> * Update ee/frontend/mobile-replay/mobile.types.ts Co-authored-by: Manoel Aranda Neto <[email protected]> * Update ee/frontend/mobile-replay/mobile.types.ts Co-authored-by: Manoel Aranda Neto <[email protected]> * Update ee/frontend/mobile-replay/mobile.types.ts Co-authored-by: Manoel Aranda Neto <[email protected]> * Update ee/frontend/mobile-replay/mobile.types.ts Co-authored-by: Manoel Aranda Neto <[email protected]> * collapse unnecessary name * gen the schema --------- Co-authored-by: test-python <[email protected]> Co-authored-by: github-actions <41898282+github-actions[bot]@users.noreply.github.com> Co-authored-by: Manoel Aranda Neto <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Sketch what inputs might look like in the schema
@marandaneto sacrificial lamb here to discuss the input schema