feat: node actions #18248
feat: node actions #18248
Conversation
📸 UI snapshots have been updated2 snapshot changes in total. 0 added, 2 modified, 0 deleted:
Triggered by this commit. |
There was a problem hiding this comment.
Not sure why these broke...
| @@ -87,7 +87,7 @@ export const TextOnly = (): JSX.Element => { | |||
| } | |||
|
|
|||
| export const Sizes = (): JSX.Element => { | |||
| const sizes: LemonButtonProps['size'][] = ['small', 'medium', 'large'] | |||
| const sizes: LemonButtonProps['size'][] = ['tiny' | 'small', 'medium', 'large'] | |||
There was a problem hiding this comment.
| const sizes: LemonButtonProps['size'][] = ['tiny' | 'small', 'medium', 'large'] | |
| const sizes: LemonButtonProps['size'][] = ['tiny', 'small', 'medium', 'large'] |
| @@ -102,7 +102,7 @@ export const Sizes = (): JSX.Element => { | |||
| } | |||
|
|
|||
| export const SizesIconOnly = (): JSX.Element => { | |||
| const sizes: LemonButtonProps['size'][] = ['small', 'medium', 'large'] | |||
| const sizes: LemonButtonProps['size'][] = ['tiny' | 'small', 'medium', 'large'] | |||
There was a problem hiding this comment.
| const sizes: LemonButtonProps['size'][] = ['tiny' | 'small', 'medium', 'large'] | |
| const sizes: LemonButtonProps['size'][] = ['tiny', 'small', 'medium', 'large'] |
| @@ -63,7 +63,7 @@ export interface LemonButtonPropsBase | |||
| /** Like plain `disabled`, except we enforce a reason to be shown in the tooltip. */ | |||
| disabledReason?: string | null | false | |||
| noPadding?: boolean | |||
| size?: 'small' | 'medium' | 'large' | |||
| size?: 'tiny' | 'small' | 'medium' | 'large' | |||
There was a problem hiding this comment.
I wonder if xsmall is better? Fits better with the tailwind-esque xs, sm, md, lg etc.
There was a problem hiding this comment.
Yep 👍 Ideally we'd move everything to the xs, sm, etc... legend
| {actions.map((x, i) => ( | ||
| <LemonButton | ||
| key={i} | ||
| size="tiny" |
There was a problem hiding this comment.
I think the below should just be
| /> | ||
| ) | ||
| }) | ||
| export const SlashCommandsPopover = forwardRef<SlashCommandsRef, SlashCommandsPopoverProps>( |
There was a problem hiding this comment.
Something in here isn't working. With one node in the book, if I click add and pick something it replaces the node....
📸 UI snapshots have been updated3 snapshot changes in total. 0 added, 3 modified, 0 deleted:
Triggered by this commit. |
daibhin
force-pushed
the
dn-feat/node-actions
branch
from
11f3e0b
to
14f593d
Compare
📸 UI snapshots have been updated3 snapshot changes in total. 0 added, 3 modified, 0 deleted:
Triggered by this commit. |
Problem
The gap cursor logic didn't feel great the first time around
Still todo: Nice empty states to further encourage insertion of nodes in empty docs
Changes
SlashCommandsPopovercomponent more generic to support new insertion optionNodeGapInsertionExtensionLemonButtonWithDropdownand add a linting rule on top of the deprecationHow did you test this code?
Made sure everything still worked manually